mirror of
https://github.com/pointfreeco/swift-composable-architecture.git
synced 2025-12-24 12:14:25 +01:00
* Fix Store leak when async effect is in flight A [Slack conversation](https://pointfreecommunity.slack.com/archives/C04KQQ7NXHV/p1702049135565039) pointed to a potential leak of the `Store` when it was executing an effect. This PR allows cancellation to properly propagate during deinitialization, and ensures that async effects don't strongly capture the store. * wip * feedback * wip
171 lines
3.9 KiB
Swift
171 lines
3.9 KiB
Swift
#if canImport(ComposableArchitectureMacros)
|
|
import ComposableArchitectureMacros
|
|
import MacroTesting
|
|
import XCTest
|
|
|
|
final class ReducerMacroTests: XCTestCase {
|
|
override func invokeTest() {
|
|
withMacroTesting(
|
|
// isRecording: true,
|
|
macros: [ReducerMacro.self]
|
|
) {
|
|
super.invokeTest()
|
|
}
|
|
}
|
|
|
|
func testBasics() {
|
|
assertMacro {
|
|
"""
|
|
@Reducer
|
|
struct Feature {
|
|
struct State {
|
|
}
|
|
enum Action {
|
|
}
|
|
var body: some ReducerOf<Self> {
|
|
EmptyReducer()
|
|
}
|
|
}
|
|
"""
|
|
} expansion: {
|
|
"""
|
|
struct Feature {
|
|
struct State {
|
|
}
|
|
@CasePathable
|
|
enum Action {
|
|
}
|
|
@ComposableArchitecture.ReducerBuilder<Self.State, Self.Action>
|
|
var body: some ReducerOf<Self> {
|
|
EmptyReducer()
|
|
}
|
|
}
|
|
|
|
extension Feature: ComposableArchitecture.Reducer {
|
|
}
|
|
"""
|
|
}
|
|
}
|
|
|
|
func testEnumState() {
|
|
assertMacro {
|
|
"""
|
|
@Reducer
|
|
struct Feature {
|
|
enum State {
|
|
}
|
|
enum Action {
|
|
}
|
|
var body: some ReducerOf<Self> {
|
|
EmptyReducer()
|
|
}
|
|
}
|
|
"""
|
|
} expansion: {
|
|
"""
|
|
struct Feature {
|
|
@CasePathable @dynamicMemberLookup
|
|
enum State {
|
|
}
|
|
@CasePathable
|
|
enum Action {
|
|
}
|
|
@ComposableArchitecture.ReducerBuilder<Self.State, Self.Action>
|
|
var body: some ReducerOf<Self> {
|
|
EmptyReducer()
|
|
}
|
|
}
|
|
|
|
extension Feature: ComposableArchitecture.Reducer {
|
|
}
|
|
"""
|
|
}
|
|
}
|
|
|
|
func testAlreadyApplied() {
|
|
assertMacro {
|
|
"""
|
|
@Reducer
|
|
struct Feature: Reducer, Sendable {
|
|
@CasePathable
|
|
@dynamicMemberLookup
|
|
enum State {
|
|
}
|
|
@CasePathable
|
|
enum Action {
|
|
}
|
|
@ReducerBuilder<State, Action>
|
|
var body: some ReducerOf<Self> {
|
|
EmptyReducer()
|
|
}
|
|
}
|
|
"""
|
|
} expansion: {
|
|
"""
|
|
struct Feature: Reducer, Sendable {
|
|
@CasePathable
|
|
@dynamicMemberLookup
|
|
enum State {
|
|
}
|
|
@CasePathable
|
|
enum Action {
|
|
}
|
|
@ReducerBuilder<State, Action>
|
|
var body: some ReducerOf<Self> {
|
|
EmptyReducer()
|
|
}
|
|
}
|
|
"""
|
|
}
|
|
}
|
|
|
|
func testReduceMethodDiagnostic() {
|
|
assertMacro {
|
|
"""
|
|
@Reducer
|
|
struct Feature {
|
|
struct State {
|
|
}
|
|
enum Action {
|
|
}
|
|
func reduce(into state: inout State, action: Action) -> EffectOf<Self> {
|
|
.none
|
|
}
|
|
var body: some ReducerOf<Self> {
|
|
Reduce(reduce)
|
|
Reduce(reduce(into:action:))
|
|
Reduce(self.reduce)
|
|
Reduce(self.reduce(into:action:))
|
|
Reduce(AnotherReducer().reduce)
|
|
Reduce(AnotherReducer().reduce(into:action:))
|
|
}
|
|
}
|
|
"""
|
|
} diagnostics: {
|
|
"""
|
|
@Reducer
|
|
struct Feature {
|
|
struct State {
|
|
}
|
|
enum Action {
|
|
}
|
|
func reduce(into state: inout State, action: Action) -> EffectOf<Self> {
|
|
┬─────
|
|
╰─ 🛑 A 'reduce' method should not be defined in a reducer with a 'body'; it takes precedence and 'body' will never be invoked
|
|
.none
|
|
}
|
|
var body: some ReducerOf<Self> {
|
|
Reduce(reduce)
|
|
Reduce(reduce(into:action:))
|
|
Reduce(self.reduce)
|
|
Reduce(self.reduce(into:action:))
|
|
Reduce(AnotherReducer().reduce)
|
|
Reduce(AnotherReducer().reduce(into:action:))
|
|
}
|
|
}
|
|
"""
|
|
}
|
|
}
|
|
}
|
|
#endif
|