averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[CSDiagnostics] Update UnableToInferGenericPackElementType to accept overloads and update test cases

Browse Source
This commit is contained in:
li3zhen1
2024-02-27 20:35:06 -05:00
parent 4779ddcb8f
commit 00b0491676
4 changed files with 49 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

71
lib/Sema/CSDiagnostics.cpp
View File

@@ -8188,49 +8188,46 @@ bool UnableToInferClosureReturnType::diagnoseAsError() {
}
bool UnableToInferGenericPackElementType::diagnoseAsError() {
const auto* locator = getLocator();
auto *locator = getLocator();
auto path = locator->getPath();
if (path.size() > 1) {
const auto applyArgToParamElt = (path.end() - 2)->getAs<LocatorPathElt::ApplyArgToParam>();
const auto packElementElt = (path.end() - 1)->getAs<LocatorPathElt::PackElement>();
if (!applyArgToParamElt)
return false;
auto anchor = getAnchor();
// `nil` appears as an element of generic pack params, let's record a
// specify contextual type for nil fix.
if (isExpr<NilLiteralExpr>(anchor)) {
emitDiagnostic(diag::unresolved_nil_literal);
}
else {
// unable to infer the type of an element of generic pack params
emitDiagnostic(diag::could_not_infer_pack_element, packElementElt->getIndex());
}
// emit callee side diagnostics
auto applyExpr = castToExpr<ApplyExpr>(locator->getAnchor());
if (auto* Fn = applyExpr->getFn()) {
if (const auto DeclRef = Fn->getReferencedDecl()) {
auto paramDecl = getParameterAt(DeclRef, applyArgToParamElt->getParamIdx());
emitDiagnosticAt(
paramDecl->getLoc(), diag::note_in_opening_pack_element,
packElementElt->getIndex() + 1, paramDecl->getNameStr());
}
}
return true;
const auto applyArgToParamElt =
(path.end() - 2)->getAs<LocatorPathElt::ApplyArgToParam>();
const auto packElementElt =
(path.end() - 1)->getAs<LocatorPathElt::PackElement>();
if (!applyArgToParamElt || !packElementElt) {
return false;
}
return false;
if (isExpr<NilLiteralExpr>(getAnchor())) {
// `nil` appears as an element of generic pack params, let's record a
// specify contextual type for nil fix.
emitDiagnostic(diag::unresolved_nil_literal);
} else {
// unable to infer the type of an element of generic pack params
emitDiagnostic(diag::could_not_infer_pack_element,
packElementElt->getIndex());
}
if (isExpr<ApplyExpr>(locator->getAnchor())) {
// emit callee side diagnostics
if (auto *calleeLocator = getSolution().getCalleeLocator(locator)) {
if (const auto choice = getOverloadChoiceIfAvailable(calleeLocator)) {
if (auto *decl = choice->choice.getDeclOrNull()) {
if (auto paramDecl =
getParameterAt(decl, applyArgToParamElt->getParamIdx())) {
emitDiagnosticAt(
paramDecl->getLoc(), diag::note_in_opening_pack_element,
packElementElt->getIndex() + 1, paramDecl->getNameStr());
}
}
}
}
}
return true;
}
static std::pair<StringRef, StringRef>
getImportModuleAndDefaultType(const ASTContext &ctx,
const ObjectLiteralExpr *expr) {