averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[CodeCompletion] Migrate postfix expr completion to solver-based

Browse Source
This commit is contained in:
Alex Hoppen
2023-03-14 16:37:14 -07:00
parent c385fe5e87
commit 00eaed3af9
25 changed files with 503 additions and 161 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
lib/Parse/ParseExpr.cpp
View File

@@ -1491,9 +1491,20 @@ Parser::parseExprPostfixSuffix(ParserResult<Expr> Result, bool isExprBasic,
return Result;
}
if (CodeCompletionCallbacks && Result.isNonNull()) {
// FIXME: We should be able to remove the InBindingPattern checks once
// apple/swift#64280 is merged.
if (CodeCompletionCallbacks && Result.isNonNull() &&
InBindingPattern != PatternBindingState::ImplicitlyImmutable &&
InBindingPattern != PatternBindingState::InVar &&
InBindingPattern != PatternBindingState::InLet) {
// Don't do postfix completions when in a binding pattern. It doesn't
// make sense to offer completions eg. in
// if let myVar#^COMPLETE^# = someOptional {}
bool hasSpace = Tok.getLoc() != getEndOfPreviousLoc();
CodeCompletionCallbacks->completePostfixExpr(Result.get(), hasSpace);
auto CCExpr =
new (Context) CodeCompletionExpr(Result.get(), Tok.getLoc());
CodeCompletionCallbacks->completePostfixExpr(CCExpr, hasSpace);
Result = makeParserResult(Result, CCExpr);
}
// Eat the code completion token because we handled it.
consumeToken(tok::code_complete);