averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[SIL] NFC: Simplify SILVTable and save 8 bytes per SILVTable

Browse Source 
We were not using the primary benefits of an intrusive list, namely the
ability to insert or remove from the middle of the list, so let's switch
to a plain vector. This also avoids linked-list pointer chasing.
This commit is contained in:
David Zarzycki
2020-06-08 10:42:04 -04:00
parent fe8893da96
commit 017ee7bf04
14 changed files with 53 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
include/swift/SIL/SILModule.h
View File

@@ -110,7 +110,7 @@ class SILModule {
public:
using FunctionListType = llvm::ilist<SILFunction>;
using GlobalListType = llvm::ilist<SILGlobalVariable>;
using VTableListType = llvm::ilist<SILVTable>;
using VTableListType = llvm::ArrayRef<SILVTable*>;
using PropertyListType = llvm::ilist<SILProperty>;
using WitnessTableListType = llvm::ilist<SILWitnessTable>;
using DefaultWitnessTableListType = llvm::ilist<SILDefaultWitnessTable>;
@@ -178,7 +178,7 @@ private:
llvm::DenseMap<const ClassDecl *, SILVTable *> VTableMap;
/// The list of SILVTables in the module.
VTableListType vtables;
std::vector<SILVTable*> vtables;
/// This is a cache of vtable entries for quick look-up
llvm::DenseMap<std::pair<const SILVTable *, SILDeclRef>, SILVTable::Entry>
@@ -404,20 +404,15 @@ public:
const_iterator zombies_begin() const { return zombieFunctions.begin(); }
const_iterator zombies_end() const { return zombieFunctions.end(); }
llvm::ArrayRef<SILVTable*> getVTables() const {
return llvm::ArrayRef<SILVTable*>(vtables);
}
using vtable_iterator = VTableListType::iterator;
using vtable_const_iterator = VTableListType::const_iterator;
VTableListType &getVTableList() { return vtables; }
const VTableListType &getVTableList() const { return vtables; }
vtable_iterator vtable_begin() { return vtables.begin(); }
vtable_iterator vtable_end() { return vtables.end(); }
vtable_const_iterator vtable_begin() const { return vtables.begin(); }
vtable_const_iterator vtable_end() const { return vtables.end(); }
iterator_range<vtable_iterator> getVTables() {
return {vtables.begin(), vtables.end()};
}
iterator_range<vtable_const_iterator> getVTables() const {
return {vtables.begin(), vtables.end()};
}
vtable_iterator vtable_begin() { return getVTables().begin(); }
vtable_iterator vtable_end() { return getVTables().end(); }
vtable_const_iterator vtable_begin() const { return getVTables().begin(); }
vtable_const_iterator vtable_end() const { return getVTables().end(); }
using witness_table_iterator = WitnessTableListType::iterator;
using witness_table_const_iterator = WitnessTableListType::const_iterator;