averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[SIL] NFC: Simplify SILVTable and save 8 bytes per SILVTable

Browse Source 
We were not using the primary benefits of an intrusive list, namely the
ability to insert or remove from the middle of the list, so let's switch
to a plain vector. This also avoids linked-list pointer chasing.
This commit is contained in:
David Zarzycki
2020-06-08 10:42:04 -04:00
parent fe8893da96
commit 017ee7bf04
14 changed files with 53 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp
View File

@@ -107,10 +107,10 @@ void CalleeCache::computeClassMethodCallees() {
// This is a little bit more complicated than to just check the VTable
// entry.Method itself, because an overridden method might be more accessible
// than the base method (e.g. a public method overrides a private method).
for (auto &VTable : M.getVTableList()) {
assert(!VTable.getClass()->hasClangNode());
for (auto &VTable : M.getVTables()) {
assert(!VTable->getClass()->hasClangNode());
for (Decl *member : VTable.getClass()->getMembers()) {
for (Decl *member : VTable->getClass()->getMembers()) {
if (auto *afd = dyn_cast<AbstractFunctionDecl>(member)) {
// If a method implementation might be overridden in another translation
// unit, also mark all the base methods as 'unknown'.
@@ -127,8 +127,8 @@ void CalleeCache::computeClassMethodCallees() {
}
// Second step: collect all implementations of a method.
for (auto &VTable : M.getVTableList()) {
for (const SILVTable::Entry &entry : VTable.getEntries()) {
for (auto &VTable : M.getVTables()) {
for (const SILVTable::Entry &entry : VTable->getEntries()) {
if (auto *afd = entry.Method.getAbstractFunctionDecl()) {
CalleesAndCanCallUnknown &callees = getOrCreateCalleesForMethod(entry.Method);
if (unknownCallees.count(afd) != 0)
@@ -308,8 +308,8 @@ void BasicCalleeAnalysis::print(llvm::raw_ostream &os) const {
os << "<no cache>\n";
}
llvm::DenseSet<SILDeclRef> printed;
for (auto &VTable : M.getVTableList()) {
for (const SILVTable::Entry &entry : VTable.getEntries()) {
for (auto &VTable : M.getVTables()) {
for (const SILVTable::Entry &entry : VTable->getEntries()) {
if (printed.insert(entry.Method).second) {
os << "callees for " << entry.Method << ":\n";
Cache->getCalleeList(entry.Method).print(os);