averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Sema: Accept if #_hasSymbol() conditions in closure contexts.

Browse Source 
Resolves rdar://100129165
This commit is contained in:
Allan Shortlidge
2022-09-27 11:20:26 -07:00
parent af276b77f5
commit 034e53ad20
7 changed files with 135 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
lib/Sema/MiscDiagnostics.cpp
View File

@@ -4302,6 +4302,50 @@ checkImplicitPromotionsInCondition(const StmtConditionElement &cond,
}
}
/// Perform MiscDiagnostics for the conditions belonging to a \c
/// LabeledConditionalStmt.
static void checkLabeledStmtConditions(ASTContext &ctx,
const LabeledConditionalStmt *stmt,
DeclContext *DC) {
for (auto elt : stmt->getCond()) {
// Check for implicit optional promotions in stmt-condition patterns.
checkImplicitPromotionsInCondition(elt, ctx);
switch (elt.getKind()) {
case StmtConditionElement::CK_Boolean:
case StmtConditionElement::CK_PatternBinding:
case StmtConditionElement::CK_Availability:
break;
case StmtConditionElement::CK_HasSymbol: {
auto info = elt.getHasSymbolInfo();
auto symbolExpr = info->getSymbolExpr();
if (!symbolExpr)
break;
if (!symbolExpr->getType())
break;
if (auto decl = info->getReferencedDecl().getDecl()) {
// `if #_hasSymbol(someStronglyLinkedSymbol)` is functionally a no-op
// and may indicate the developer has mis-identified the declaration
// they want to check (or forgot to import the module weakly).
if (!decl->isWeakImported(DC->getParentModule())) {
ctx.Diags.diagnose(symbolExpr->getLoc(),
diag::has_symbol_decl_must_be_weak,
decl->getDescriptiveKind(), decl->getName());
}
} else {
// Diagnose because we weren't able to interpret the expression as one
// that uniquely identifies a single declaration.
ctx.Diags.diagnose(symbolExpr->getLoc(), diag::has_symbol_invalid_expr);
}
break;
}
}
}
}
static void diagnoseUnintendedOptionalBehavior(const Expr *E,
const DeclContext *DC) {
if (!E || isa<ErrorExpr>(E) || !E->getType())
@@ -5290,11 +5334,9 @@ void swift::performStmtDiagnostics(const Stmt *S, DeclContext *DC) {
checkSwitch(ctx, switchStmt, DC);
checkStmtConditionTrailingClosure(ctx, S);
// Check for implicit optional promotions in stmt-condition patterns.
if (auto *lcs = dyn_cast<LabeledConditionalStmt>(S))
for (const auto &elt : lcs->getCond())
checkImplicitPromotionsInCondition(elt, ctx);
checkLabeledStmtConditions(ctx, lcs, DC);
if (!ctx.LangOpts.DisableAvailabilityChecking)
diagnoseStmtAvailability(S, const_cast<DeclContext*>(DC));