averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #27123 from hborla/missing-conformance-diag

Browse Source 
[ConstraintSystem] Allow fixing missing conformance failures for `Void` and uninhabited types.
This commit is contained in:
Holly Borla
2019-09-12 17:41:19 -07:00
committed by GitHub
parent 5664045d01 b2ec5b97b9
commit 0434d58ff0
5 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/Sema/CSSimplify.cpp
View File

@@ -3901,11 +3901,6 @@ ConstraintSystem::SolutionKind ConstraintSystem::simplifyConformsToConstraint(
return recordFix(fix) ? SolutionKind::Error : SolutionKind::Solved;
}
// Let's not try to fix missing conformance for Void
// or Never because that doesn't really make sense.
if (type->isVoid() || type->isUninhabited())
return SolutionKind::Error;
if (path.back().is<LocatorPathElt::AnyRequirement>()) {
// If this is a requirement associated with `Self` which is bound
// to `Any`, let's consider this "too incorrect" to continue.