averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #33370 from bitjammer/acgarland/rdar-65258208-crash-invalid-loc-extracttext

Browse Source 
[SymbolGraph] Check Loc validity before extracting text
This commit is contained in:
AG
2020-08-10 11:56:53 -07:00
committed by GitHub
parent d8bef6ece2 635550cd83
commit 05c33330c9
3 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/IDE/SourceEntityWalker.cpp
View File

@@ -685,7 +685,7 @@ bool SemaAnnotator::
passReference(ValueDecl *D, Type Ty, DeclNameLoc Loc, ReferenceMetaData Data) {
SourceManager &SM = D->getASTContext().SourceMgr;
SourceLoc BaseStart = Loc.getBaseNameLoc(), BaseEnd = BaseStart;
if (SM.extractText({BaseStart, 1}) == "`")
if (BaseStart.isValid() && SM.extractText({BaseStart, 1}) == "`")
BaseEnd = Lexer::getLocForEndOfToken(SM, BaseStart.getAdvancedLoc(1));
return passReference(D, Ty, BaseStart, {BaseStart, BaseEnd}, Data);
}