averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #39831 from hborla/invalid-selector-property

Browse Source 
[ConstraintSystem] Don't increase the score for unapplied function references if the expression is an argument to `#selector`.
This commit is contained in:
Holly Borla
2021-10-20 19:37:48 -07:00
committed by GitHub
parent 9481130c8b 57d0bf8c71
commit 0601498ce7
3 changed files with 19 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/Sema/ConstraintSystem.cpp
View File

@@ -3000,7 +3000,13 @@ void ConstraintSystem::resolveOverload(ConstraintLocator *locator,
}
if (isa<AbstractFunctionDecl>(decl) || isa<TypeDecl>(decl)) {
if (choice.getFunctionRefKind() == FunctionRefKind::Unapplied) {
auto anchor = locator->getAnchor();
// TODO: Instead of not increasing the score for arguments to #selector,
// a better fix for this is to port over the #selector diagnostics from
// CSApply to constraint fixes, and not attempt invalid disjunction
// choices based on the selector kind on the valid code path.
if (choice.getFunctionRefKind() == FunctionRefKind::Unapplied &&
!UnevaluatedRootExprs.contains(getAsExpr(anchor))) {
increaseScore(SK_UnappliedFunction);
}
}