averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Diagnostics] Produce a tailored diagnostic for property wrapper argument mismatch

Browse Source 
Diagnose an attempt to initialize a property, which has a property
wrapper, with a value of an incorrect type.
This commit is contained in:
Pavel Yaskevich
2019-11-11 12:59:28 -08:00
parent 47aa97708e
commit 08f8f4191d
4 changed files with 35 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
lib/Sema/CSDiagnostics.cpp
View File

@@ -5303,6 +5303,9 @@ bool ArgumentMismatchFailure::diagnoseAsError() {
if (diagnoseUseOfReferenceEqualityOperator())
return true;
if (diagnosePropertyWrapperMismatch())
return true;
auto argType = getFromType();
auto paramType = getToType();
@@ -5542,6 +5545,32 @@ bool ArgumentMismatchFailure::diagnoseMisplacedMissingArgument() const {
return failure.diagnoseSingleMissingArgument();
}
bool ArgumentMismatchFailure::diagnosePropertyWrapperMismatch() const {
auto argType = getFromType();
auto paramType = getToType();
// Verify that this is an implicit call to a property wrapper initializer
// in a form of `init(wrappedValue:)` or deprecated `init(initialValue:)`.
auto *call = dyn_cast<CallExpr>(getRawAnchor());
if (!(call && call->isImplicit() && isa<TypeExpr>(call->getFn()) &&
call->getNumArguments() == 1 &&
(call->getArgumentLabels().front() == getASTContext().Id_wrappedValue ||
call->getArgumentLabels().front() == getASTContext().Id_initialValue)))
return false;
auto argExpr = cast<TupleExpr>(call->getArg())->getElement(0);
// If this is an attempt to initialize property wrapper with opaque value
// of error type, let's just ignore that problem since original mismatch
// has been diagnosed already.
if (argExpr->isImplicit() && isa<OpaqueValueExpr>(argExpr) &&
argType->is<ErrorType>())
return true;
emitDiagnostic(getLoc(), diag::cannot_convert_initializer_value, argType,
paramType);
return true;
}
void ExpandArrayIntoVarargsFailure::tryDropArrayBracketsFixIt(
Expr *anchor) const {
// If this is an array literal, offer to remove the brackets and pass the