averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[sourcekitd] Fix some compiler warnings

Browse Source 
* remove nullability attribute from a non-pointer argument
* const-correctness on custom buffer casts
* remove statically unreachable code
This commit is contained in:
Ben Langmuir
2018-04-19 14:20:51 -07:00
parent 1d66f0ab50
commit 0aa11cb6b2
3 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
tools/SourceKit/lib/SwiftLang/SwiftCompletion.cpp
View File

@@ -865,7 +865,6 @@ static bool canonicalizeFilterName(const char *origName,
continue; continue;
} }
} }
llvm_unreachable("exit is on null byte");
} }
static void translateFilterRules(ArrayRef<FilterRule> rawFilterRules, static void translateFilterRules(ArrayRef<FilterRule> rawFilterRules,

2
tools/SourceKit/tools/sourcekitd/include/sourcekitd/sourcekitd.h
View File

@@ -351,7 +351,7 @@ SOURCEKITD_PUBLIC SOURCEKITD_NONNULL1 SOURCEKITD_WARN_RESULT
sourcekitd_variant_t sourcekitd_variant_t
sourcekitd_response_get_value(sourcekitd_response_t resp); sourcekitd_response_get_value(sourcekitd_response_t resp);
SOURCEKITD_PUBLIC SOURCEKITD_NONNULL_ALL SOURCEKITD_WARN_RESULT SOURCEKITD_PUBLIC SOURCEKITD_WARN_RESULT
sourcekitd_variant_type_t sourcekitd_variant_type_t
sourcekitd_variant_get_type(sourcekitd_variant_t obj); sourcekitd_variant_get_type(sourcekitd_variant_t obj);

4
tools/SourceKit/tools/sourcekitd/lib/API/sourcekitdAPI-XPC.cpp
View File

@@ -583,9 +583,9 @@ sourcekitd_response_get_value(sourcekitd_response_t resp) {
#define XPC_OBJ(var) ((xpc_object_t)(var).data[1]) #define XPC_OBJ(var) ((xpc_object_t)(var).data[1])
#define CUSTOM_BUF_KIND(xobj) \ #define CUSTOM_BUF_KIND(xobj) \
((CustomBufferKind)*(uint64_t*)xpc_data_get_bytes_ptr(xobj)) ((CustomBufferKind)*(const uint64_t*)xpc_data_get_bytes_ptr(xobj))
#define CUSTOM_BUF_START(xobj) \ #define CUSTOM_BUF_START(xobj) \
((void*)(((uint64_t*)xpc_data_get_bytes_ptr(xobj))+1)) ((const void*)(((const uint64_t*)xpc_data_get_bytes_ptr(xobj))+1))
static sourcekitd_variant_type_t XPCVar_get_type(sourcekitd_variant_t var) { static sourcekitd_variant_type_t XPCVar_get_type(sourcekitd_variant_t var) {
xpc_object_t obj = XPC_OBJ(var); xpc_object_t obj = XPC_OBJ(var);