averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Diagnostics] NFC: Remove "trailing" from method name for closures with missing args

Browse Source 
`MissingArgumentsFailure::diagnoseClosure` can actually diagnose both
closures in argument positions as well as when their type comes from
context e.g. `let _: (Int) -> Void = {}`.
This commit is contained in:
Pavel Yaskevich
2019-09-17 10:34:40 -07:00
parent 4d02463e2b
commit 0aeaf7f15e
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/Sema/CSDiagnostics.cpp
View File

@@ -3509,12 +3509,12 @@ bool MissingArgumentsFailure::diagnoseAsError() {
anchor = captureList->getClosureBody(); anchor = captureList->getClosureBody();
if (auto *closure = dyn_cast<ClosureExpr>(anchor)) if (auto *closure = dyn_cast<ClosureExpr>(anchor))
return diagnoseTrailingClosure(closure); return diagnoseClosure(closure);
return false; return false;
} }
bool MissingArgumentsFailure::diagnoseTrailingClosure(ClosureExpr *closure) { bool MissingArgumentsFailure::diagnoseClosure(ClosureExpr *closure) {
auto &cs = getConstraintSystem(); auto &cs = getConstraintSystem();
FunctionType *funcType = nullptr; FunctionType *funcType = nullptr;

4
lib/Sema/CSDiagnostics.h
View File

@@ -1192,9 +1192,9 @@ public:
bool diagnoseAsError() override; bool diagnoseAsError() override;
private: private:
/// If missing arguments come from trailing closure, /// If missing arguments come from a closure,
/// let's produce tailored diagnostics. /// let's produce tailored diagnostics.
bool diagnoseTrailingClosure(ClosureExpr *closure); bool diagnoseClosure(ClosureExpr *closure);
}; };
class OutOfOrderArgumentFailure final : public FailureDiagnostic { class OutOfOrderArgumentFailure final : public FailureDiagnostic {