averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't emit upcast to the same type in SimplifyAllocRefDynamic, add test, add comment

Browse Source
This commit is contained in:
Kuba Mracek
2024-09-24 08:48:51 -07:00
parent d1e3828281
commit 0b50c2155e
3 changed files with 34 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
SwiftCompilerSources/Sources/Optimizer/InstructionSimplification/SimplifyAllocRefDynamic.swift
View File

@@ -26,11 +26,14 @@ extension AllocRefDynamicInst : OnoneSimplifyable {
/// %8 = (... some use of ...) %7 : $BaseClass
let type: Type
let emitUpcast: Bool
if let metatypeInst = metatypeOperand.value as? MetatypeInst {
type = metatypeInst.type.loweredInstanceTypeOfMetatype(in: parentFunction)
emitUpcast = false
} else if let upcastInst = metatypeOperand.value as? UpcastInst,
let metatypeInst = upcastInst.operands[0].value as? MetatypeInst {
type = metatypeInst.type.loweredInstanceTypeOfMetatype(in: parentFunction)
emitUpcast = true
} else {
return
}
@@ -38,8 +41,14 @@ extension AllocRefDynamicInst : OnoneSimplifyable {
let builder = Builder(before: self, context)
let newAlloc = builder.createAllocRef(type, isObjC: self.isObjC, canAllocOnStack: self.canAllocOnStack, isBare: false,
tailAllocatedTypes: self.tailAllocatedTypes, tailAllocatedCounts: Array(self.tailAllocatedCounts.values))
let newCast = builder.createUpcast(from: newAlloc, to: self.type)
uses.replaceAll(with: newCast, context)
let result: Value
if emitUpcast {
result = builder.createUpcast(from: newAlloc, to: self.type)
} else {
result = newAlloc
}
uses.replaceAll(with: result, context)
context.erase(instruction: self)
}
}