averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[NFC] Remove caching for "isOverlay" computation when emitting a trace.

Browse Source 
Based on measurements, it seemed to save about 0.2 ms - 0.4 ms for a module
with a large number of imports from the SDK. That's insignificant compared to
the compile time for a typical module, which usually takes somewhere between
a few seconds and a few minutes.
This commit is contained in:
Varun Gandhi
2020-08-08 01:02:40 -07:00
parent 99cefe707e
commit 0ca8458189
1 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/FrontendTool/FrontendTool.cpp
View File

@@ -328,9 +328,6 @@ class ABIDependencyEvaluator {
llvm::DenseSet<ModuleDecl *> visited;
/// Cache to avoid recomputing public imports of Swift modules repeatedly.
llvm::DenseMap<ModuleDecl *, bool> isOverlayCache;
/// Helper function to handle invariant violations as crashes in debug mode.
void crashOnInvariantViolation(
llvm::function_ref<void (llvm::raw_string_ostream &)> f) const;
@@ -484,10 +481,6 @@ void ABIDependencyEvaluator::reexposeImportedABI(
bool ABIDependencyEvaluator::isOverlayOfClangModule(ModuleDecl *swiftModule) {
assert(!swiftModule->isNonSwiftModule());
auto cacheEntry = isOverlayCache.find(swiftModule);
if (cacheEntry != isOverlayCache.end())
return cacheEntry->second;
llvm::SmallPtrSet<ModuleDecl *, 8> importList;
::getImmediateImports(swiftModule, importList,
{ModuleDecl::ImportFilterKind::Public});
@@ -495,7 +488,6 @@ bool ABIDependencyEvaluator::isOverlayOfClangModule(ModuleDecl *swiftModule) {
llvm::any_of(importList, [&](ModuleDecl *importedModule) -> bool {
return isClangOverlayOf(swiftModule, importedModule);
});
isOverlayCache[swiftModule] = isOverlay;
return isOverlay;
}