averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[benchmark] Fix index computation for quantiles

Browse Source 
Turns out that both the old code in `DriverUtils` that computed median, as well as newer quartiles in `PerformanceTestSamples` had off-by-1 error.

It trully is the 3rd of the 2 hard things in computer science!
This commit is contained in:
Pavol Vaskovic
2018-08-30 06:52:58 +02:00
parent 5cd9f53840
commit 0db20feda2
3 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
benchmark/scripts/test_compare_perf_tests.py
View File

@@ -78,10 +78,10 @@ class TestPerformanceTestSamples(unittest.TestCase):
self.samples, (1000, 1000, 1100, 1100, 1100))
self.samples.add(Sample(3, 1, 1050))
self.assertEqualFiveNumberSummary(
self.samples, (1000, 1000, 1050, 1050, 1100))
self.samples, (1000, 1050, 1050, 1100, 1100))
self.samples.add(Sample(4, 1, 1025))
self.assertEqualFiveNumberSummary(
self.samples, (1000, 1025, 1050, 1100, 1100))
self.samples, (1000, 1025, 1050, 1050, 1100))
self.samples.add(Sample(5, 1, 1075))
self.assertEqualFiveNumberSummary(
self.samples, (1000, 1025, 1050, 1075, 1100))
@@ -156,11 +156,12 @@ class TestPerformanceTestSamples(unittest.TestCase):
self.samples.add(Sample(0, 2, 23))
self.samples.add(Sample(1, 2, 18))
self.samples.add(Sample(2, 2, 18))
self.samples.add(Sample(3, 2, 18))
self.assertEquals(self.samples.iqr, 0)
self.samples.exclude_outliers()
self.assertEquals(self.samples.count, 2)
self.assertEquals(self.samples.count, 3)
self.assertEqualStats(
(self.samples.min, self.samples.max), (18, 18))