averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

AST: Optimize construction of the global name lookup table

Browse Source 
Only visit bodies of types and extensions that may possibly contain
operator definitions.
This commit is contained in:
Slava Pestov
2019-08-12 16:44:30 -04:00
parent bbdc7ae8e5
commit 14d0bbfc5e
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/AST/Module.cpp
View File

@@ -189,13 +189,16 @@ template<typename Range>
void SourceLookupCache::doPopulateCache(Range decls,
bool onlyOperators) {
for (Decl *D : decls) {
if (auto *VD = dyn_cast<ValueDecl>(D))
if (auto *VD = dyn_cast<ValueDecl>(D)) {
if (onlyOperators ? VD->isOperator() : VD->hasName()) {
// Cache the value under both its compound name and its full name.
TopLevelValues.add(VD);
}
}
if (auto *NTD = dyn_cast<NominalTypeDecl>(D))
doPopulateCache(NTD->getMembers(), true);
if (!NTD->hasUnparsedMembers() || NTD->maybeHasOperatorDeclarations())
doPopulateCache(NTD->getMembers(), true);
// Avoid populating the cache with the members of invalid extension
// declarations. These members can be used to point validation inside of
@@ -203,7 +206,8 @@ void SourceLookupCache::doPopulateCache(Range decls,
if (D->isInvalid()) continue;
if (auto *ED = dyn_cast<ExtensionDecl>(D))
doPopulateCache(ED->getMembers(), true);
if (!ED->hasUnparsedMembers() || ED->maybeHasOperatorDeclarations())
doPopulateCache(ED->getMembers(), true);
}
}