averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Prefix opt-remark ID with sil "namespace"

Browse Source 
This is so that we can unambiguously distinguish from LLVM opt remarks.
This commit is contained in:
Adam Nemet
2017-12-05 20:42:53 -08:00
parent 1191901e55
commit 1520cbe6dd
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/SIL/OptimizationRemark.cpp
View File

@@ -134,7 +134,7 @@ template <typename KindT> struct MappingTraits<Remark<KindT>> {
// them. // them.
StringRef PassName = R.getPassName(); StringRef PassName = R.getPassName();
io.mapRequired("Pass", PassName); io.mapRequired("Pass", PassName);
StringRef Id = R.getIdentifier(); std::string Id = (Twine("sil.") + R.getIdentifier()).str();
io.mapRequired("Name", Id); io.mapRequired("Name", Id);
SourceLoc Loc = R.getLocation(); SourceLoc Loc = R.getLocation();

2
test/Driver/opt-record.swift
View File

@@ -15,7 +15,7 @@ func foo() {
public func bar() { public func bar() {
// YAML: --- !Passed // YAML: --- !Passed
// YAML-NEXT: Pass: sil-inliner // YAML-NEXT: Pass: sil-inliner
// YAML-NEXT: Name: Inlined // YAML-NEXT: Name: sil.Inlined
// YAML-NEXT: DebugLoc: // YAML-NEXT: DebugLoc:
// YAML-NEXT: File: {{.*}}opt-record.swift // YAML-NEXT: File: {{.*}}opt-record.swift
// YAML-NEXT: Line: 42 // YAML-NEXT: Line: 42

4
test/SILOptimizer/inliner_coldblocks.sil
View File

@@ -196,7 +196,7 @@ bb0:
// REMARKS_PASSED: inliner_coldblocks.sil:223:3: remark: "update_global" inlined into "regular_large_callee" (cost = {{.*}}, benefit = {{.*}}) // REMARKS_PASSED: inliner_coldblocks.sil:223:3: remark: "update_global" inlined into "regular_large_callee" (cost = {{.*}}, benefit = {{.*}})
// YAML: --- !Passed // YAML: --- !Passed
// YAML-NEXT: Pass: sil-inliner // YAML-NEXT: Pass: sil-inliner
// YAML-NEXT: Name: Inlined // YAML-NEXT: Name: sil.Inlined
// YAML-NEXT: DebugLoc: // YAML-NEXT: DebugLoc:
// YAML-NEXT: File: {{.*}}inliner_coldblocks.sil // YAML-NEXT: File: {{.*}}inliner_coldblocks.sil
// YAML-NEXT: Line: 223 // YAML-NEXT: Line: 223
@@ -236,7 +236,7 @@ bb0:
// REMARKS_MISSED: inliner_coldblocks.sil:258:8: remark: Not profitable to inline function "regular_large_callee" (cost = {{.*}}, benefit = {{.*}}) // REMARKS_MISSED: inliner_coldblocks.sil:258:8: remark: Not profitable to inline function "regular_large_callee" (cost = {{.*}}, benefit = {{.*}})
// YAML: --- !Missed // YAML: --- !Missed
// YAML-NEXT: Pass: sil-inliner // YAML-NEXT: Pass: sil-inliner
// YAML-NEXT: Name: NoInlinedCost // YAML-NEXT: Name: sil.NoInlinedCost
// YAML-NEXT: DebugLoc: // YAML-NEXT: DebugLoc:
// YAML-NEXT: File: {{.*}}inliner_coldblocks.sil // YAML-NEXT: File: {{.*}}inliner_coldblocks.sil
// YAML-NEXT: Line: 258 // YAML-NEXT: Line: 258

4
test/SILOptimizer/specialize.sil
View File

@@ -21,7 +21,7 @@ import Swift
// YAML: --- !Passed // YAML: --- !Passed
// YAML-NEXT: Pass: sil-generic-specializer // YAML-NEXT: Pass: sil-generic-specializer
// YAML-NEXT: Name: Specialized // YAML-NEXT: Name: sil.Specialized
// YAML-NEXT: DebugLoc: // YAML-NEXT: DebugLoc:
// YAML-NEXT: File: {{.*}}/specialize.sil // YAML-NEXT: File: {{.*}}/specialize.sil
// YAML-NEXT: Line: 132 // YAML-NEXT: Line: 132
@@ -39,7 +39,7 @@ import Swift
// YAML-NEXT: ... // YAML-NEXT: ...
// YAML-NEXT: --- !Passed // YAML-NEXT: --- !Passed
// YAML-NEXT: Pass: sil-generic-specializer // YAML-NEXT: Pass: sil-generic-specializer
// YAML-NEXT: Name: Specialized // YAML-NEXT: Name: sil.Specialized
// YAML-NEXT: DebugLoc: // YAML-NEXT: DebugLoc:
// YAML-NEXT: File: {{.*}}/specialize.sil // YAML-NEXT: File: {{.*}}/specialize.sil
// YAML-NEXT: Line: 142 // YAML-NEXT: Line: 142

2
test/SILOptimizer/specialize_no_definition.sil
View File

@@ -8,7 +8,7 @@ sil_stage canonical
// CHECK: --- !Missed // CHECK: --- !Missed
// CHECK-NEXT: Pass: sil-generic-specializer // CHECK-NEXT: Pass: sil-generic-specializer
// CHECK-NEXT: Name: NoDef // CHECK-NEXT: Name: sil.NoDef
// CHECK-NEXT: DebugLoc: // CHECK-NEXT: DebugLoc:
// CHECK-NEXT: File: {{.*}}/specialize_no_definition.sil // CHECK-NEXT: File: {{.*}}/specialize_no_definition.sil
// CHECK-NEXT: Line: 36 // CHECK-NEXT: Line: 36