averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[AST] Use cached deserialized decl in getOpaqueResultTypeDecl

Browse Source 
Mangling and looking up the opaque result type decl
for serialized decls is a fairly expensive
operation. Instead, fallthrough to the request
which will have a cached value set by deserialization.
This shaves ~30ms off the cached completion for:

```swift
import SwiftUI

struct V: View {
  var body: some View {
    Table(#^CC^#
  }
}
```
This commit is contained in:
Hamish Knight
2024-11-04 11:29:55 +00:00
parent 43839ac5fd
commit 152812cc86
7 changed files with 69 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

53
lib/Serialization/Deserialization.cpp
View File

@@ -3936,14 +3936,17 @@ public:
if (var->hasStorage())
AddAttribute(new (ctx) HasStorageAttr(/*isImplicit:*/true));
if (opaqueReturnTypeID) {
auto opaqueReturnType = MF.getDeclChecked(opaqueReturnTypeID);
if (!opaqueReturnType)
return opaqueReturnType.takeError();
{
OpaqueTypeDecl *opaqueDecl = nullptr;
if (opaqueReturnTypeID) {
auto opaqueReturnType = MF.getDeclChecked(opaqueReturnTypeID);
if (!opaqueReturnType)
return opaqueReturnType.takeError();
ctx.evaluator.cacheOutput(
OpaqueResultTypeRequest{var},
cast<OpaqueTypeDecl>(opaqueReturnType.get()));
opaqueDecl = cast<OpaqueTypeDecl>(opaqueReturnType.get());
}
ctx.evaluator.cacheOutput(OpaqueResultTypeRequest{var},
std::move(opaqueDecl));
}
// If this is a lazy property, record its backing storage.
@@ -4357,14 +4360,17 @@ public:
fn->setIsObjC(isObjC);
fn->setForcedStaticDispatch(hasForcedStaticDispatch);
if (opaqueReturnTypeID) {
auto declOrError = MF.getDeclChecked(opaqueReturnTypeID);
if (!declOrError)
return declOrError.takeError();
{
OpaqueTypeDecl *opaqueDecl = nullptr;
if (opaqueReturnTypeID) {
auto declOrError = MF.getDeclChecked(opaqueReturnTypeID);
if (!declOrError)
return declOrError.takeError();
ctx.evaluator.cacheOutput(
OpaqueResultTypeRequest{fn},
cast<OpaqueTypeDecl>(declOrError.get()));
opaqueDecl = cast<OpaqueTypeDecl>(declOrError.get());
}
ctx.evaluator.cacheOutput(OpaqueResultTypeRequest{fn},
std::move(opaqueDecl));
}
if (!isAccessor)
@@ -5204,16 +5210,19 @@ public:
subscript->setOverriddenDecl(cast_or_null<SubscriptDecl>(overridden.get()));
if (subscript->getOverriddenDecl())
AddAttribute(new (ctx) OverrideAttr(SourceLoc()));
if (opaqueReturnTypeID) {
Decl *opaqueReturnType;
UNWRAP(MF.getDeclChecked(opaqueReturnTypeID), opaqueReturnType);
ctx.evaluator.cacheOutput(
OpaqueResultTypeRequest{subscript},
cast<OpaqueTypeDecl>(opaqueReturnType));
{
OpaqueTypeDecl *opaqueDecl = nullptr;
if (opaqueReturnTypeID) {
Decl *opaqueReturnType;
UNWRAP(MF.getDeclChecked(opaqueReturnTypeID), opaqueReturnType);
opaqueDecl = cast<OpaqueTypeDecl>(opaqueReturnType);
}
ctx.evaluator.cacheOutput(OpaqueResultTypeRequest{subscript},
std::move(opaqueDecl));
}
return subscript;
}