averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[CodeCompletion] Provide known module source file information"

Browse Source 
This effectively reverts commit f8751d466e.
This commit is contained in:
Rintaro Ishizaki
2021-09-21 14:40:16 -07:00
parent 9fb54e95ae
commit 1656eed597
14 changed files with 20 additions and 338 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/IDE/CodeCompletionCache.cpp
View File

@@ -102,7 +102,7 @@ CodeCompletionCache::~CodeCompletionCache() {}
///
/// This should be incremented any time we commit a change to the format of the
/// cached results. This isn't expected to change very often.
static constexpr uint32_t onDiskCompletionCacheVersion = 2;
static constexpr uint32_t onDiskCompletionCacheVersion = 3; // Removed "source file path".
/// Deserializes CodeCompletionResults from \p in and stores them in \p V.
/// \see writeCacheModule.
@@ -209,7 +209,6 @@ static bool readCachedModule(llvm::MemoryBuffer *in,
auto numBytesToErase = static_cast<unsigned>(*cursor++);
auto chunkIndex = read32le(cursor);
auto moduleIndex = read32le(cursor);
auto sourceFilePathIndex = read32le(cursor);
auto briefDocIndex = read32le(cursor);
auto diagMessageIndex = read32le(cursor);
@@ -221,7 +220,6 @@ static bool readCachedModule(llvm::MemoryBuffer *in,
CodeCompletionString *string = getCompletionString(chunkIndex);
auto moduleName = getString(moduleIndex);
auto sourceFilePath = getString(sourceFilePathIndex);
auto briefDocComment = getString(briefDocIndex);
auto diagMessage = getString(diagMessageIndex);
@@ -229,7 +227,7 @@ static bool readCachedModule(llvm::MemoryBuffer *in,
if (kind == CodeCompletionResult::Declaration) {
result = new (*V.Sink.Allocator) CodeCompletionResult(
context, CodeCompletionFlair(), numBytesToErase, string,
declKind, isSystem, moduleName, sourceFilePath, notRecommended,
declKind, isSystem, moduleName, notRecommended,
diagSeverity, diagMessage, briefDocComment,
copyArray(*V.Sink.Allocator, ArrayRef<StringRef>(assocUSRs)),
CodeCompletionResult::Unknown, opKind);
@@ -369,7 +367,6 @@ static void writeCachedModule(llvm::raw_ostream &out,
LE.write(
static_cast<uint32_t>(addCompletionString(R->getCompletionString())));
LE.write(addString(R->getModuleName())); // index into strings
LE.write(addString(R->getSourceFilePath())); // index into strings
LE.write(addString(R->getBriefDocComment())); // index into strings
LE.write(addString(R->getDiagnosticMessage())); // index into strings