averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[CSSimplify] Delay binding generic argument type variables to any Sendable

Browse Source 
Prevent generic arguments from being assigned `any Sendable`
directly, that should only happen through inference. This is
required because we allow `any Sendable` -> `Any` conversion
in modes without strict concurrency enabled to maintain source
compatibility and let the developers annotate existing APIs
with `any Sendable` and other concurrency attributes.
This commit is contained in:
Pavel Yaskevich
2024-12-10 13:22:27 -08:00
parent 02b4bac7fc
commit 17093b35d7
1 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/Sema/CSSimplify.cpp
View File

@@ -4311,6 +4311,20 @@ ConstraintSystem::matchTypesBindTypeVar(
type = type->getRValueType();
}
// Prevent generic arguments from being assigned `any Sendable`
// directly, that should only happen through inference. This is
// required because we allow `any Sendable` -> `Any` conversion
// in modes without strict concurrency enabled to maintain source
// compatibility and let the developers annotate existing APIs
// with `any Sendable` and other concurrency attributes.
if (typeVar->getImpl().getGenericParameter() &&
!flags.contains(TMF_BindingTypeVariable) &&
type->isMarkerExistential()) {
auto constraintTy = type->castTo<ExistentialType>()->getConstraintType();
if (constraintTy->getKnownProtocol() == KnownProtocolKind::Sendable)
return formUnsolvedResult();
}
// Attempt to fix situations where type variable can't be bound
// to a particular type e.g. `l-value` or `inout`.
auto fixReferenceMismatch = [&](TypeVariableType *typeVar,