averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Set debug location to Coroutine call expression

Browse Source 
If debug info generation is enabled, set debug location to the
coroutine call instruction to make sure there are no issues with invalid
debug information in LTO.

This happens because in LTO, if a call to a function doesn't contain a
debug location, we see the warning:

inlinable function call in a function with debug info must have a
!dbg location

ld: warning: Invalid debug info found, debug info will be stripped

Which then strips the debug info from the entire .o file linked into the
dylib.
This commit is contained in:
Shubham Sandeep Rastogi
2025-05-12 17:35:15 -07:00
parent 602a1168a1
commit 17e756ba81
2 changed files with 21 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/IRGen/GenCall.cpp
View File

@@ -5023,6 +5023,8 @@ static void emitRetconCoroutineEntry(
for (auto *arg : finalArguments) { for (auto *arg : finalArguments) {
arguments.push_back(arg); arguments.push_back(arg);
} }
ArtificialLocation Loc(IGF.getDebugScope(), IGF.IGM.DebugInfo.get(),
IGF.Builder);
llvm::Value *id = IGF.Builder.CreateIntrinsicCall(idIntrinsic, arguments); llvm::Value *id = IGF.Builder.CreateIntrinsicCall(idIntrinsic, arguments);
// Call 'llvm.coro.begin', just for consistency with the normal pattern. // Call 'llvm.coro.begin', just for consistency with the normal pattern.
@@ -5127,7 +5129,6 @@ void irgen::emitYieldOnceCoroutineEntry(
allocFn = IGF.IGM.getOpaquePtr(IGF.IGM.getMallocFn()); allocFn = IGF.IGM.getOpaquePtr(IGF.IGM.getMallocFn());
} }
ArtificialLocation Loc(IGF.getDebugScope(), IGF.IGM.DebugInfo.get(), IGF.Builder);
emitRetconCoroutineEntry(IGF, fnType, buffer, emitRetconCoroutineEntry(IGF, fnType, buffer,
llvm::Intrinsic::coro_id_retcon_once, llvm::Intrinsic::coro_id_retcon_once,
getYieldOnceCoroutineBufferSize(IGF.IGM), getYieldOnceCoroutineBufferSize(IGF.IGM),

19
test/IRGen/CoroutineAccessorsDebugLoc.swift Normal file
View File

@@ -0,0 +1,19 @@
// REQUIRES: swift_feature_CoroutineAccessors
// RUN: %target-swift-frontend %s -g -c -O -o - -emit-irgen -enable-experimental-feature CoroutineAccessors | %FileCheck %s
// This test checks to made sure that the ReadAccessor s26CoroutineAccessorsDebugLoc1SV3irmSivr that has a call to @llvm.coro.id.retcon.once, also has a debug location set.
// CHECK-LABEL: @"$s26CoroutineAccessorsDebugLoc1SV3irmSivr"
// CHECK: %{{.*}} = call token ({{.*}}) @llvm.coro.id.retcon.once({{.*}}), !dbg ![[DBGLOC:[0-9]+]]
// CHECK-NEXT: %{{.*}} = call ptr @llvm.coro.begin({{.*}}), !dbg ![[DBGLOC]]
public struct S {
public var o: any AnyObject
public var _i: Int = 0
public var irm: Int {
_read {
yield _i
}
} // public var irm
}