averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

StringOptimization: handle inlined global accessors.

Browse Source 
In case a global accessor is inlined, the `global_addr` and it's `builtin "once"` call is visible in the SIL instead of the call to the global initializer.
This commit is contained in:
Erik Eckstein
2023-05-08 13:32:32 +02:00
parent 56c09c3aed
commit 19b828bcec
1 changed files with 40 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

59
lib/SILOptimizer/Transforms/StringOptimization.cpp
View File

@@ -581,25 +581,43 @@ StringOptimization::getStringFromStaticLet(SILValue value) {
auto *load = dyn_cast<LoadInst>(value);
if (!load)
return StringInfo::unknown();
auto *pta = dyn_cast<PointerToAddressInst>(load->getOperand());
if (!pta)
SILFunction *initializer = nullptr;
auto *globalAddr = dyn_cast<GlobalAddrInst>(load->getOperand());
if (globalAddr) {
// The global accessor is inlined.
// Usually the global_addr is immediately preceeded by a call to
// `builtin "once"` which initializes the global.
SILInstruction *prev = globalAddr->getPreviousInstruction();
if (!prev)
return StringInfo::unknown();
auto *bi = dyn_cast<BuiltinInst>(prev);
if (!bi || bi->getBuiltinInfo().ID != BuiltinValueKind::Once)
return StringInfo::unknown();
initializer = getCalleeOfOnceCall(bi);
} else {
// The global accessor is not inlined, yet.
auto *pta = dyn_cast<PointerToAddressInst>(load->getOperand());
if (!pta)
return StringInfo::unknown();
auto *addressorCall = dyn_cast<ApplyInst>(pta->getOperand());
if (!addressorCall)
return StringInfo::unknown();
SILFunction *addressorFunc = addressorCall->getReferencedFunctionOrNull();
if (!addressorFunc)
return StringInfo::unknown();
// The addressor function has a builtin.once call to the initializer.
BuiltinInst *onceCall = nullptr;
initializer = findInitializer(addressorFunc, onceCall);
}
if (!initializer || !initializer->isGlobalInitOnceFunction())
return StringInfo::unknown();
auto *addressorCall = dyn_cast<ApplyInst>(pta->getOperand());
if (!addressorCall)
return StringInfo::unknown();
SILFunction *addressorFunc = addressorCall->getReferencedFunctionOrNull();
if (!addressorFunc)
return StringInfo::unknown();
// The addressor function has a builtin.once call to the initializer.
BuiltinInst *onceCall = nullptr;
SILFunction *initializer = findInitializer(addressorFunc, onceCall);
if (!initializer)
return StringInfo::unknown();
if (initializer->size() != 1)
return StringInfo::unknown();
@@ -618,7 +636,10 @@ StringOptimization::getStringFromStaticLet(SILValue value) {
}
if (!gAddr || !gAddr->getReferencedGlobal()->isLet())
return StringInfo::unknown();
if (globalAddr && globalAddr->getReferencedGlobal() != gAddr->getReferencedGlobal())
return StringInfo::unknown();
Operand *gUse = gAddr->getSingleUse();
auto *store = dyn_cast<StoreInst>(gUse->getUser());
if (!store || store->getDest() != gAddr)