averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Test / Sema: Change the wording of assignment through read-only key path error

Browse Source
This commit is contained in:
Sam Lazarus
2019-05-02 19:42:54 -04:00
parent cefbb12ed2
commit 1a1e77077a
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/Sema/CSDiagnostics.cpp
View File

@@ -989,16 +989,16 @@ bool AssignmentFailure::diagnoseAsError() {
if (!choice->isDecl()) {
if (choice->getKind() == OverloadChoiceKind::KeyPathApplication &&
!isa<ApplyExpr>(immInfo.first)) {
std::string message = "the key path";
std::string message = "";
if (auto *SE = dyn_cast<SubscriptExpr>(immInfo.first)) {
if (auto *tupleExpr = dyn_cast<TupleExpr>(SE->getIndex())) {
if (auto *DRE = dyn_cast<DeclRefExpr>(tupleExpr->getElement(0))) {
auto identifier = DRE->getDecl()->getBaseName().getIdentifier();
message = "'" + identifier.str().str() + "'";
message = "'" + identifier.str().str() + "' ";
}
}
}
emitDiagnostic(Loc, DeclDiagnostic, message + " is a read-only key path")
emitDiagnostic(Loc, DeclDiagnostic, message + "is read-only")
.highlight(immInfo.first->getSourceRange());
return true;
}
@@ -1016,7 +1016,7 @@ bool AssignmentFailure::diagnoseAsError() {
auto type = getType(immInfo.first);
if (isKnownKeyPathType(type))
message += " is a read-only key path";
message += " is read-only";
else if (VD->isCaptureList())
message += " is an immutable capture";
else if (VD->isImplicit())