averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Sema] Diagnose internal(set) from @inlinable functions

Browse Source 
This patch mainly consolidates the functions used to check accessors vs.
other decls, and makes sure we check setter access as well as regular
decl access.

rdar://45217648
This commit is contained in:
Harlan Haskins
2018-12-07 12:46:19 -08:00
parent d30a3da32a
commit 1abeeb8b92
8 changed files with 94 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
include/swift/AST/DiagnosticsSema.def
View File

@@ -4104,27 +4104,33 @@ ERROR(usable_from_inline_attr_in_protocol,none,
"a default argument value|" \
"a property initializer in a '@_fixed_layout' type}"
#define DECL_OR_ACCESSOR "%select{%0|%0 for}"
ERROR(local_type_in_inlinable_function,
none, "type %0 cannot be nested inside " FRAGILE_FUNC_KIND "1",
(DeclName, unsigned))
ERROR(resilience_decl_unavailable,
none, "%0 %1 is %select{private|fileprivate|internal|%error|%error}2 and "
none, DECL_OR_ACCESSOR "4 %1 is %select{private|fileprivate|internal|%error|%error}2 and "
"cannot be referenced from " FRAGILE_FUNC_KIND "3",
(DescriptiveDeclKind, DeclName, AccessLevel, unsigned))
(DescriptiveDeclKind, DeclName, AccessLevel, unsigned, bool))
WARNING(resilience_decl_unavailable_warn,
none, "%0 %1 is %select{private|fileprivate|internal|%error|%error}2 and "
none, DECL_OR_ACCESSOR "4 %1 is %select{private|fileprivate|internal|%error|%error}2 and "
"should not be referenced from " FRAGILE_FUNC_KIND "3",
(DescriptiveDeclKind, DeclName, AccessLevel, unsigned))
(DescriptiveDeclKind, DeclName, AccessLevel, unsigned, bool))
#undef FRAGILE_FUNC_KIND
NOTE(resilience_decl_declared_here_public,
none, "%0 %1 is not public", (DescriptiveDeclKind, DeclName))
none, DECL_OR_ACCESSOR "2 %1 is not public",
(DescriptiveDeclKind, DeclName, bool))
NOTE(resilience_decl_declared_here,
none, "%0 %1 is not '@usableFromInline' or public", (DescriptiveDeclKind, DeclName))
none, DECL_OR_ACCESSOR "2 %1 is not '@usableFromInline' or public",
(DescriptiveDeclKind, DeclName, bool))
#undef DECL_OR_ACCESSOR
ERROR(class_designated_init_inlinable_resilient,none,
"initializer for class %0 is "