averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Driver] Track the latest a particular job could have been run.

Browse Source 
This is mostly just a matter of not throwing away mtimes we were already
looking up. We can compare these values to the mtimes of cross-module
dependencies to find out what's been updated.

Part of rdar://problem/19270920

Swift SVN r24336
This commit is contained in:
Jordan Rose
2015-01-10 00:38:11 +00:00
parent 5e889c0c8a
commit 1b7cd80d1d
2 changed files with 52 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
lib/Driver/Driver.cpp
View File

@@ -1304,18 +1304,37 @@ static void addAuxiliaryOutput(CommandOutput &output, types::ID outputType,
/// than the file at \p output.
///
/// If there is any error (such as either file not existing), returns false.
static bool inputIsOlderThanOutput(StringRef input, StringRef output) {
if (input.empty() || output.empty())
return false;
static void
handleCompileJobCondition(Job *J,
CompileJobAction::BuildState previousBuildState,
StringRef input,
StringRef output) {
llvm::sys::fs::file_status inputStatus;
if (llvm::sys::fs::status(input, inputStatus))
return;
llvm::sys::fs::file_status inputStatus, outputStatus;
if (llvm::sys::fs::status(input, inputStatus) ||
llvm::sys::fs::status(output, outputStatus)) {
return false;
J->updatePreviousBuildTime(inputStatus.getLastModificationTime());
llvm::sys::fs::file_status outputStatus;
if (llvm::sys::fs::status(output, outputStatus))
return;
if (!J->updatePreviousBuildTime(outputStatus.getLastModificationTime()))
return;
Job::Condition condition;
switch (previousBuildState) {
case CompileJobAction::BuildState::UpToDate:
condition = Job::Condition::CheckDependencies;
break;
case CompileJobAction::BuildState::NeedsCascadingBuild:
condition = Job::Condition::Always;
break;
case CompileJobAction::BuildState::NeedsNonCascadingBuild:
condition = Job::Condition::RunWithoutCascading;
break;
}
return inputStatus.getLastModificationTime() <
outputStatus.getLastModificationTime();
J->setCondition(condition);
}
Job *Driver::buildJobsForAction(const Compilation &C, const Action *A,
@@ -1520,21 +1539,10 @@ Job *Driver::buildJobsForAction(const Compilation &C, const Action *A,
// If we track dependencies for this job, we may be able to avoid running it.
if (!J->getOutput().getAdditionalOutputForType(types::TY_SwiftDeps).empty()) {
if (InputActions.size() == 1 &&
inputIsOlderThanOutput(BaseInput, OutputFile)) {
Job::Condition condition;
switch (cast<CompileJobAction>(A)->getPreviousBuildState()) {
case CompileJobAction::BuildState::UpToDate:
condition = Job::Condition::CheckDependencies;
break;
case CompileJobAction::BuildState::NeedsCascadingBuild:
condition = Job::Condition::Always;
break;
case CompileJobAction::BuildState::NeedsNonCascadingBuild:
condition = Job::Condition::RunWithoutCascading;
break;
}
J->setCondition(condition);
if (InputActions.size() == 1) {
auto compileJob = cast<CompileJobAction>(A);
handleCompileJobCondition(J, compileJob->getPreviousBuildState(),
BaseInput, OutputFile);
}
}