averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[ConstraintSystem] NFC: While diagnosing operator ambiguity use Identifier::is to compare names

Browse Source
This commit is contained in:
Pavel Yaskevich
2019-12-04 10:40:13 -08:00
parent 94b4052321
commit 1be60a7c56
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/Sema/ConstraintSystem.cpp
View File

@@ -2583,10 +2583,10 @@ static void diagnoseOperatorAmbiguity(ConstraintSystem &cs,
if (!applyExpr)
return;
auto isNameOfStandardComparisonOperator = [](StringRef opName) -> bool {
return opName == "==" || opName == "!=" || opName == "===" ||
opName == "!==" || opName == "<" || opName == ">" ||
opName == "<=" || opName == ">=";
auto isNameOfStandardComparisonOperator = [](Identifier opName) -> bool {
return opName.is("==") || opName.is("!=") || opName.is("===") ||
opName.is("!==") || opName.is("<") || opName.is(">") ||
opName.is("<=") || opName.is(">=");
};
auto isEnumWithAssociatedValues = [](Type type) -> bool {
@@ -2609,7 +2609,7 @@ static void diagnoseOperatorAmbiguity(ConstraintSystem &cs,
.highlight(lhs->getSourceRange())
.highlight(rhs->getSourceRange());
if (isNameOfStandardComparisonOperator(operatorName.str()) &&
if (isNameOfStandardComparisonOperator(operatorName) &&
isEnumWithAssociatedValues(lhsType)) {
DE.diagnose(applyExpr->getLoc(),
diag::no_binary_op_overload_for_enum_with_payload,