averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #41917 from ahoppen/pr/filter-overloads-if-no-cc-token

Browse Source 
[CodeCompletion] Filter overloads if their function application doesn't contain the code completion token
This commit is contained in:
Alex Hoppen
2022-03-22 12:11:29 +01:00
committed by GitHub
parent 2697e96e1c 045302b4cb
commit 1ef2c5972c
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/Sema/CSSimplify.cpp
View File

@@ -10774,8 +10774,12 @@ bool ConstraintSystem::simplifyAppliedOverloadsImpl(
// Don't attempt to filter overloads when solving for code completion
// because presence of code completion token means that any call
// could be malformed e.g. missing arguments e.g. `foo([.#^MEMBER^#`
if (isForCodeCompletion())
return false;
if (isForCodeCompletion()) {
bool ArgContainsCCTypeVar = Type(argFnType).findIf(isCodeCompletionTypeVar);
if (ArgContainsCCTypeVar || isCodeCompletionTypeVar(fnTypeVar)) {
return false;
}
}
if (shouldAttemptFixes()) {
auto arguments = argFnType->getParams();