averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[CSBindings] Open collection before binding parameter only if original argument type failed

Browse Source 
Instead of always opening argument type represented by a collection
without type variables (to support subtyping when element is a labeled tuple),
let's try original type first and if that fails use a slower path with
indirection which attempts `array upcast`. Doing it this way helps to
propagate contextual information faster which fixes a performance regression.

Resolves: rdar://problem/54580247
This commit is contained in:
Pavel Yaskevich
2020-02-27 15:04:43 -08:00
parent 0fb4ea1ec3
commit 20fc51d4f4
4 changed files with 25 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/Sema/CSSimplify.cpp
View File

@@ -3799,9 +3799,11 @@ bool ConstraintSystem::repairFailures(
if (tupleLocator->isLastElement<LocatorPathElt::SequenceElementType>())
break;
// Generic argument failures have a more general fix which is attached to a
// parent type and aggregates all argument failures into a single fix.
if (tupleLocator->isLastElement<LocatorPathElt::GenericArgument>())
// Generic argument/requirement failures have a more general fix which
// is attached to a parent type and aggregates all argument failures
// into a single fix.
if (tupleLocator->isLastElement<LocatorPathElt::AnyRequirement>() ||
tupleLocator->isLastElement<LocatorPathElt::GenericArgument>())
break;
ConstraintFix *fix;