averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Sema: Split up gatherConstraints() into gatherAllConstraints() and gatherNearbyConstraints()

Browse Source 
The two GatherKinds no longer share any implementation, so there's
no point keeping the logic together. Doing this also allows removing
the acceptConstraintFn from gatherAllConstraints(), which further
simplifies depthFirstSearch().
This commit is contained in:
Slava Pestov
2025-01-24 14:22:01 -05:00
parent 881c4f775b
commit 2230c3a17e
7 changed files with 38 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
include/swift/Sema/ConstraintGraph.h
View File

@@ -300,25 +300,18 @@ public:
/// to a type variable.
void introduceToInference(TypeVariableType *typeVar, Type fixedType);
/// Describes which constraints \c gatherConstraints should gather.
enum class GatheringKind {
/// Gather constraints associated with all of the variables within the
/// same equivalence class as the given type variable, as well as its
/// immediate fixed bindings.
EquivalenceClass,
/// Gather all constraints that mention this type variable or type variables
/// that it is a fixed binding of. Unlike EquivalenceClass, this looks
/// through transitive fixed bindings. This can be used to find all the
/// constraints that may be affected when binding a type variable.
AllMentions,
};
/// Gather the set of constraints that involve the given type variable,
/// i.e., those constraints that will be affected when the type variable
/// gets merged or bound to a fixed type.
/// Gather constraints associated with all of the variables within the
/// same equivalence class as the given type variable, as well as its
/// immediate fixed bindings.
llvm::TinyPtrVector<Constraint *>
gatherConstraints(TypeVariableType *typeVar,
GatheringKind kind,
gatherAllConstraints(TypeVariableType *typeVar);
/// Gather all constraints that mention this type variable or type variables
/// that it is a fixed binding of. Unlike EquivalenceClass, this looks
/// through transitive fixed bindings. This can be used to find all the
/// constraints that may be affected when binding a type variable.
llvm::TinyPtrVector<Constraint *>
gatherNearbyConstraints(TypeVariableType *typeVar,
llvm::function_ref<bool(Constraint *)> acceptConstraint =
[](Constraint *constraint) { return true; });