[ParseableInterface] Turn on -enable-parseable-module-interface always (#23331)

...and remove the option. This is ~technically~ CLI-breaking because
Swift 5 shipped this as a hidden driver option, but it wouldn't have
/done/ anything in Swift 5, so I think it's okay to remove.

Note that if a parseable interface (.swiftinterface) and a binary
interface (.swiftmodule) are both present, the binary one will still
be preferred. This just /allows/ parseable interfaces to be used.

rdar://problem/36885834
This commit is contained in:
Jordan Rose
2019-03-16 15:31:11 -07:00
committed by GitHub
parent dbe99d771e
commit 22f9853b76
33 changed files with 70 additions and 97 deletions

View File

@@ -258,7 +258,6 @@ class swift::ParseableInterfaceBuilder {
void configureSubInvocationInputsAndOutputs(StringRef OutPath) {
auto &SubFEOpts = subInvocation.getFrontendOptions();
SubFEOpts.RequestedAction = FrontendOptions::ActionType::EmitModuleOnly;
SubFEOpts.EnableParseableModuleInterface = true;
SubFEOpts.InputsAndOutputs.addPrimaryInputFile(interfacePath);
SupplementaryOutputPaths SOPs;
SOPs.ModuleOutputPath = OutPath.str();
@@ -713,9 +712,6 @@ class ParseableInterfaceModuleLoaderImpl {
if (validationInfo.status != serialization::Status::Valid)
return false;
assert(validationInfo.name == moduleName &&
"we built a module at this path with a different name?");
return dependenciesAreUpToDate(allDeps);
}