averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[Diagnostics] Don't try to diagnose immutability failures in boolean context

Browse Source
This commit is contained in:
Pavel Yaskevich
2019-09-20 13:32:14 -07:00
parent f8afae9444
commit 232185ec72
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/Sema/CSDiagnostics.cpp
View File

@@ -1294,6 +1294,13 @@ bool RValueTreatedAsLValueFailure::diagnoseAsError() {
Expr *diagExpr = getRawAnchor();
SourceLoc loc = diagExpr->getLoc();
auto &cs = getConstraintSystem();
// Assignment is not allowed inside of a condition,
// so let's not diagnose immutability, because
// most likely the problem is related to use of `=` itself.
if (cs.getContextualTypePurpose() == CTP_Condition)
return false;
if (auto assignExpr = dyn_cast<AssignExpr>(diagExpr)) {
diagExpr = assignExpr->getDest();
}