averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #24097 from xedin/diag-mutating-getter-in-keypath

Browse Source 
[ConstraintSystem] Detect and diagnoses use of members with mutating getters in key path
This commit is contained in:
Pavel Yaskevich
2019-04-18 13:12:22 -07:00
committed by GitHub
parent 86e4467c52 eaf1dc0012
commit 23403500bd
7 changed files with 164 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
lib/Sema/CSDiagnostics.cpp
View File

@@ -2453,9 +2453,8 @@ bool KeyPathSubscriptIndexHashableFailure::diagnoseAsError() {
return true;
}
bool InvalidStaticMemberRefInKeyPath::diagnoseAsError() {
SourceLoc InvalidMemberRefInKeyPath::getLoc() const {
auto *anchor = getRawAnchor();
auto loc = anchor->getLoc();
if (auto *KPE = dyn_cast<KeyPathExpr>(anchor)) {
auto *locator = getLocator();
@@ -2465,9 +2464,18 @@ bool InvalidStaticMemberRefInKeyPath::diagnoseAsError() {
});
assert(component != locator->getPath().end());
loc = KPE->getComponents()[component->getValue()].getLoc();
return KPE->getComponents()[component->getValue()].getLoc();
}
emitDiagnostic(loc, diag::expr_keypath_static_member, Member->getBaseName());
return anchor->getLoc();
}
bool InvalidStaticMemberRefInKeyPath::diagnoseAsError() {
emitDiagnostic(getLoc(), diag::expr_keypath_static_member, getName());
return true;
}
bool InvalidMemberWithMutatingGetterInKeyPath::diagnoseAsError() {
emitDiagnostic(getLoc(), diag::expr_keypath_mutating_getter, getName());
return true;
}