Sema: Remove BindingSet::operator bool

2025-12-21 12:14:44 +01:00 · 2025-11-12 18:03:00 -05:00
parent 4c977c6b81
commit 23a7ca04bf
4 changed files with 10 additions and 8 deletions
--- a/lib/Sema/CSOptimizer.cpp
+++ b/lib/Sema/CSOptimizer.cpp
@@ -1105,7 +1105,9 @@ static void determineBestChoicesInContext(
      // Simply adding it as a binding won't work because if the second argument
      // is non-optional the overload that returns `T?` would still have a lower
      // score.
-      if (!bindingSet && isNilCoalescingOperator(disjunction)) {
+      if (!bindingSet.hasViableBindings() &&
+          !bindingSet.isDirectHole() &&
+          isNilCoalescingOperator(disjunction)) {
        auto &cg = cs.getConstraintGraph();
        if (llvm::any_of(cg[typeVar].getConstraints(),
                         [&typeVar](Constraint *constraint) {