averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[sil-combine] Fix a subtle bug in getConformanceAndConcreteType related to handling of inherited conformances

Browse Source 
This fixes a couple of tests and some of the compatibility suite projects.
rdar://problem/31815540, rdar://problem/31838976
This commit is contained in:
Roman Levenstein
2017-04-26 16:57:32 -07:00
parent b3053cffd7
commit 28d7f80c24
3 changed files with 35 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
test/SILOptimizer/devirt_protocol_method_invocations.swift
View File

@@ -1,5 +1,30 @@
// RUN: %target-swift-frontend -O -emit-sil %s | %FileCheck %s
protocol PPP {
func f()
}
protocol QQQ : PPP {
}
struct S : QQQ {}
extension QQQ {
@_semantics("optimize.sil.never")
func f() {}
}
// Test that all witness_method instructions are devirtualized.
// This test used to crash the compiler because it uses inherited conformances.
// CHECK-LABEL: sil @_T034devirt_protocol_method_invocations24testInheritedConformanceyyF : $@convention(thin) () -> ()
// CHECK-NOT: witness_method
// CHECK-NOT: class_method
// CHECK: apply
// CHECK: // end sil function '_T034devirt_protocol_method_invocations24testInheritedConformanceyyF'
public func testInheritedConformance() {
(S() as QQQ).f()
}
public protocol Foo {
func foo(_ x:Int) -> Int
}
@@ -49,12 +74,10 @@ public func test_devirt_protocol_extension_method_invocation_with_self_return_ty
return callGetSelf(c)
}
// It's not obvious why this isn't completely devirtualized.
// CHECK: sil @_T034devirt_protocol_method_invocations12test24114020SiyF
// CHECK: [[T0:%.*]] = alloc_stack $SimpleBase
// CHECK: [[T1:%.*]] = witness_method $SimpleBase, #Base.x!getter.1
// CHECK: [[T2:%.*]] = apply [[T1]]<SimpleBase>([[T0]])
// CHECK: return [[T2]]
// CHECK: [[T0:%.*]] = integer_literal $Builtin.Int64, 1
// CHECK: [[T1:%.*]] = struct $Int ([[T0]] : $Builtin.Int64)
// CHECK: return [[T1]]
// CHECK: sil @_T034devirt_protocol_method_invocations14testExMetatypeSiyF
// CHECK: [[T0:%.*]] = builtin "sizeof"<Int>