averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

ABI: Only store bitwise take-able values inline

Browse Source 
SR-343
rdar://31414907
This commit is contained in:
Arnold Schwaighofer
2018-05-21 12:49:44 -07:00
parent b823db802f
commit 298067496d
10 changed files with 112 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
stdlib/public/runtime/Enum.cpp
View File

@@ -89,12 +89,14 @@ swift::swift_initEnumMetadataSinglePayload(EnumMetadata *self,
auto vwtable = getMutableVWTableForInit(self, layoutFlags);
size_t align = payloadLayout->flags.getAlignment();
bool isBT = payloadLayout->flags.isBitwiseTakable();
TypeLayout layout;
layout.size = size;
layout.flags = payloadLayout->flags
.withExtraInhabitants(unusedExtraInhabitants > 0)
.withEnumWitnesses(true)
.withInlineStorage(ValueWitnessTable::isValueInline(size, align));
layout.flags =
payloadLayout->flags.withExtraInhabitants(unusedExtraInhabitants > 0)
.withEnumWitnesses(true)
.withInlineStorage(
ValueWitnessTable::isValueInline(isBT, size, align));
auto rawStride = llvm::alignTo(size, align);
layout.stride = rawStride == 0 ? 1 : rawStride;
@@ -200,14 +202,14 @@ swift::swift_initEnumMetadataMultiPayload(EnumMetadata *enumType,
TypeLayout layout;
layout.size = totalSize;
layout.flags = ValueWitnessFlags()
.withAlignmentMask(alignMask)
.withPOD(isPOD)
.withBitwiseTakable(isBT)
// TODO: Extra inhabitants
.withExtraInhabitants(false)
.withEnumWitnesses(true)
.withInlineStorage(ValueWitnessTable::isValueInline(totalSize, alignMask+1))
;
.withAlignmentMask(alignMask)
.withPOD(isPOD)
.withBitwiseTakable(isBT)
// TODO: Extra inhabitants
.withExtraInhabitants(false)
.withEnumWitnesses(true)
.withInlineStorage(ValueWitnessTable::isValueInline(
isBT, totalSize, alignMask + 1));
auto rawStride = (totalSize + alignMask) & ~alignMask;
layout.stride = rawStride == 0 ? 1 : rawStride;