averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

[ParseableInterface] Fix failing to build a module when the importing file has errors.

Browse Source 
We were checking the parent invocation's DiagnosticEnginer rather than the
subinstance's to determine if there were any errors building the module, which
meant we would fail to load the module if there were errors prior to the import
statement in the importing file.

This also meant code completion would fail to load the module, because it always
emits a bogus error in order to mark the AST as erroneous so that different
parts of the compiler (e.g. the verifier) have less strict assumptions.

rdar://problem/43906499
This commit is contained in:
Nathan Hawes
2019-02-07 16:52:30 -08:00
parent 1e7fba716d
commit 2a746da9bc
6 changed files with 80 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
test/SourceKit/CodeComplete/complete_swiftinterface.swift Normal file
View File

@@ -0,0 +1,28 @@
// RUN: %empty-directory(%t)
// RUN: %empty-directory(%t/modulecache)
// 1) Build .swiftinterface files for MyPoint and MyExtensions
// RUN: %target-swift-frontend -emit-parseable-module-interface-path %t/MyPoint.swiftinterface -module-name MyPoint -emit-module -o /dev/null %S/Inputs/parseable-interface/MyPoint.swift
// RUN: %target-swift-frontend -emit-parseable-module-interface-path %t/MyPointExtensions.swiftinterface -module-name MyPointExtensions -emit-module -o /dev/null -enable-parseable-module-interface -module-cache-path %t/modulecache -I %t %S/Inputs/parseable-interface/MyPointExtensions.swift
// 2) Check completion with a warm module cache from above
// RUN: %swift-ide-test_plain -code-completion -code-completion-token=MEMBER -source-filename %s -I %t -module-cache-path %t/modulecache | %FileCheck %s
// 3) Check completion with a cold module cache
// RUN: %empty-directory(%t/modulecache)
// RUN: %swift-ide-test_plain -code-completion -code-completion-token=MEMBER -source-filename %s -I %t -module-cache-path %t/modulecache | %FileCheck %s
import MyPoint
import MyPointExtensions
let x = MyPoint(x: 1, y: 10.5)
print(x.#^MEMBER^#)
// CHECK: Begin completions, 5 items
// CHECK: Keyword[self]/CurrNominal: self[#MyPoint#]; name=self
// CHECK: Decl[InstanceVar]/CurrNominal: x[#Double#]; name=x
// CHECK: Decl[InstanceVar]/CurrNominal: y[#Double#]; name=y
// CHECK: Decl[InstanceVar]/CurrNominal: magnitudeSquared[#Double#]; name=magnitudeSquared
// CHECK: Decl[InstanceVar]/CurrNominal: magnitude[#Double#]; name=magnitude
// CHECK: End completions