averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

swift-api-digester: don't assume super classes are always present in the module dump.

Browse Source 
When we compare the APIs of entire SDKs, we can assume super classes
are always present in the API dump. However, this assumption is invalid
for framework-level API diff checking, where super classes can come from
other modules whose contents are not serialized.

rdar://33110442
This commit is contained in:
Xi Ge
2017-07-06 11:49:42 -07:00
parent e4de4ea9de
commit 2b05e30756
5 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/swift-api-digester/swift-api-digester.cpp
View File

@@ -729,8 +729,10 @@ public:
Optional<SDKNodeTypeDecl*> getSuperclass() const {
if (SuperclassUsr.empty())
return None;
return (*getRootNode()->getDescendantByUsr(SuperclassUsr))->
getAs<SDKNodeTypeDecl>();
if (auto SC = getRootNode()->getDescendantByUsr(SuperclassUsr)) {
return (*SC)->getAs<SDKNodeTypeDecl>();
}
return None;
}
/// Finding the node through all children, including the inheritted ones,