averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #66513 from xedin/init-accessor-diagnostics

Browse Source 
[Sema/SIL] Improve diagnostics related to init accessors
This commit is contained in:
Pavel Yaskevich
2023-06-14 09:57:08 -07:00
committed by GitHub
parent 183902da47 34c8cf60f1
commit 2b8a39724c
17 changed files with 738 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
lib/SILOptimizer/Mandatory/DefiniteInitialization.cpp
View File

@@ -1154,14 +1154,38 @@ void LifetimeChecker::doIt() {
// All of the indirect results marked as "out" have to be fully initialized
// before their lifetime ends.
if (TheMemory.isOut() && Uses.empty()) {
auto loc = TheMemory.getLoc();
if (TheMemory.isOut()) {
auto diagnoseMissingInit = [&]() {
std::string propertyName;
auto *property = TheMemory.getPathStringToElement(0, propertyName);
diagnose(Module, F.getLocation(),
diag::ivar_not_initialized_by_init_accessor,
property->getName());
EmittedErrorLocs.push_back(TheMemory.getLoc());
};
std::string propertyName;
auto *property = TheMemory.getPathStringToElement(0, propertyName);
diagnose(Module, F.getLocation(),
diag::ivar_not_initialized_by_init_accessor, property->getName());
EmittedErrorLocs.push_back(loc);
// No uses means that there was no initialization.
if (Uses.empty()) {
diagnoseMissingInit();
return;
}
// Go over every return block and check whether member is fully initialized
// because it's possible that there is branch that doesn't have any use of
// the memory and nothing else is going to diagnose that. This is different
// from `self`, for example, because it would always have either `copy_addr`
// or `load` before return.
auto returnBB = F.findReturnBB();
while (returnBB != F.end()) {
auto *terminator = returnBB->getTerminator();
if (!isInitializedAtUse(DIMemoryUse(terminator, DIUseKind::Load, 0, 1)))
diagnoseMissingInit();
++returnBB;
}
}
// If the memory object has nontrivial type, then any destroy/release of the