averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[SIL Builder] Don't try to micro-optimize away a bool parameter with NDEBUG

Browse Source
This commit is contained in:
Doug Gregor
2023-06-02 20:12:33 -07:00
parent 386c180d32
commit 2c98c7d13c
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
include/swift/SIL/SILBuilder.h
View File

@@ -413,11 +413,9 @@ public:
AllocStackInst *createAllocStack(SILLocation Loc, SILType elementType,
Optional<SILDebugVariable> Var = None,
bool hasDynamicLifetime = false,
bool isLexical = false, bool wasMoved = false
#ifndef NDEBUG
,
bool isLexical = false,
bool wasMoved = false,
bool skipVarDeclAssert = false
#endif
) {
llvm::SmallString<4> Name;
Loc.markAsPrologue();
@@ -425,6 +423,8 @@ public:
if (dyn_cast_or_null<VarDecl>(Loc.getAsASTNode<Decl>()))
assert((skipVarDeclAssert || Loc.isSynthesizedAST() || Var) &&
"location is a VarDecl, but SILDebugVariable is empty");
#else
(void)skipVarDeclAssert;
#endif
return insert(AllocStackInst::create(
getSILDebugLocation(Loc, true), elementType, getFunction(),
@@ -473,19 +473,20 @@ public:
return createAllocBox(loc, SILBoxType::get(fieldType.getASTType()), Var,
hasDynamicLifetime, reflection,
usesMoveableValueDebugInfo,
/*skipVarDeclAssert*/ false, hasPointerEscape);
/*skipVarDeclAssert*/ false,
hasPointerEscape);
}
AllocBoxInst *createAllocBox(SILLocation Loc, CanSILBoxType BoxType,
Optional<SILDebugVariable> Var = None,
bool hasDynamicLifetime = false,
bool reflection = false,
bool usesMoveableValueDebugInfo = false
#ifndef NDEBUG
,
bool usesMoveableValueDebugInfo = false,
bool skipVarDeclAssert = false,
#endif
bool hasPointerEscape = false) {
#if NDEBUG
(void)skipVarDeclAssert;
#endif
llvm::SmallString<4> Name;
Loc.markAsPrologue();
assert((skipVarDeclAssert ||