averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[SIL] Require explicit releasenone.

Browse Source 
Functions which which consume their arguments will release them on any
branches where the arguments are unused.  Users of `@_effects(readnone)`
and `@_effects(readonly)` may not consider this when annotating their
functions.  Require that functions annotated thus are also annotated
@_effects(releasenone).

In order to support this, adjust SILFunctionBuilder to allow distinct
non-custom effects and to interpret such "conflicting" guarantees to
provide the strongest guarantee.  For example, annotating a function
both `@_effects(readnone)` and `@_effects(releasenone)` is equivalent to
only annotating it `@_effects(readnone)`.
This commit is contained in:
Nate Chandler
2023-09-05 08:01:43 -07:00
parent 63bdb4ab1f
commit 2ca262c03a
3 changed files with 195 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

78
lib/SIL/IR/SILFunctionBuilder.cpp
View File

@@ -13,9 +13,10 @@
#include "swift/SIL/SILFunctionBuilder.h"
#include "swift/AST/AttrKind.h"
#include "swift/AST/Availability.h"
#include "swift/AST/DiagnosticsParse.h"
#include "swift/AST/DistributedDecl.h"
#include "swift/AST/Decl.h"
#include "swift/AST/DiagnosticsParse.h"
#include "swift/AST/DiagnosticsSIL.h"
#include "swift/AST/DistributedDecl.h"
#include "swift/AST/ParameterList.h"
#include "swift/AST/SemanticAttrs.h"
@@ -60,6 +61,8 @@ void SILFunctionBuilder::addFunctionAttributes(
if (auto *A = Attrs.getAttribute(DAK_EmitAssemblyVisionRemarks))
F->addSemanticsAttr(semantics::FORCE_EMIT_OPT_REMARK_PREFIX);
auto *attributedFuncDecl = constant.getAbstractFunctionDecl();
// Propagate @_specialize.
for (auto *A : Attrs.getAttributes<SpecializeAttr>()) {
auto *SA = cast<SpecializeAttr>(A);
@@ -103,21 +106,74 @@ void SILFunctionBuilder::addFunctionAttributes(
}
}
EffectsAttr const *writeNoneEffect = nullptr;
EffectsAttr const *releaseNoneEffect = nullptr;
llvm::SmallVector<const EffectsAttr *, 8> customEffects;
if (constant) {
for (auto *attr : Attrs.getAttributes<EffectsAttr>()) {
auto *effectsAttr = cast<EffectsAttr>(attr);
if (effectsAttr->getKind() == EffectsKind::Custom) {
switch (effectsAttr->getKind()) {
case EffectsKind::Custom:
customEffects.push_back(effectsAttr);
} else {
if (F->getEffectsKind() != EffectsKind::Unspecified &&
F->getEffectsKind() != effectsAttr->getKind()) {
mod.getASTContext().Diags.diagnose(effectsAttr->getLocation(),
diag::warning_in_effects_attribute, "mismatching function effects");
} else {
F->setEffectsKind(effectsAttr->getKind());
}
// Proceed to the next attribute, don't set the effects kind based on
// this attribute.
continue;
case EffectsKind::ReadNone:
case EffectsKind::ReadOnly:
writeNoneEffect = effectsAttr;
break;
case EffectsKind::ReleaseNone:
releaseNoneEffect = effectsAttr;
break;
default:
break;
}
if (effectsAttr->getKind() == EffectsKind::Custom)
continue;
if (F->getEffectsKind() != EffectsKind::Unspecified) {
// If multiple known effects are specified, the most restrictive one
// is used.
F->setEffectsKind(
std::min(effectsAttr->getKind(), F->getEffectsKind()));
} else {
F->setEffectsKind(effectsAttr->getKind());
}
}
}
if (writeNoneEffect && !releaseNoneEffect) {
auto constantType = mod.Types.getConstantFunctionType(
TypeExpansionContext::minimal(), constant);
SILFunctionConventions fnConv(constantType, mod);
auto selfIndex = fnConv.getSILArgIndexOfSelf();
for (auto index : indices(fnConv.getParameters())) {
auto param = fnConv.getParameters()[index];
if (!param.isConsumed())
continue;
if (index == selfIndex) {
mod.getASTContext().Diags.diagnose(
writeNoneEffect->getLocation(),
diag::
error_attr_effects_consume_requires_explicit_releasenone_self);
} else {
auto *pd = attributedFuncDecl->getParameters()->get(index);
mod.getASTContext().Diags.diagnose(
writeNoneEffect->getLocation(),
diag::error_attr_effects_consume_requires_explicit_releasenone,
pd->getName());
mod.getASTContext().Diags.diagnose(
pd->getNameLoc(),
diag::note_attr_effects_consume_requires_explicit_releasenone,
pd->getName());
}
mod.getASTContext()
.Diags
.diagnose(
writeNoneEffect->getLocation(),
diag::fixit_attr_effects_consume_requires_explicit_releasenone)
.fixItInsertAfter(writeNoneEffect->getRange().End,
" @_effects(releasenone)");
}
}