From 2d255e7129052d0efcd79f6fd95b5725de5a628c Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Mon, 3 Jun 2024 14:04:30 +0100 Subject: [PATCH] [cxx-interop][SwiftCompilerSources] Remove a workaround The definition of `~BasicCalleeAnalysis` can now be inlined. rdar://127152872 / resolves https://github.com/apple/swift/issues/64502 --- include/swift/SILOptimizer/Analysis/BasicCalleeAnalysis.h | 2 +- lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp | 4 ---- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/include/swift/SILOptimizer/Analysis/BasicCalleeAnalysis.h b/include/swift/SILOptimizer/Analysis/BasicCalleeAnalysis.h index 281cc53f104..d48c4792cf2 100644 --- a/include/swift/SILOptimizer/Analysis/BasicCalleeAnalysis.h +++ b/include/swift/SILOptimizer/Analysis/BasicCalleeAnalysis.h @@ -37,7 +37,7 @@ public: BasicCalleeAnalysis(SILModule *M) : SILAnalysis(SILAnalysisKind::BasicCallee), M(*M), Cache(nullptr) {} - ~BasicCalleeAnalysis(); + ~BasicCalleeAnalysis() {} static bool classof(const SILAnalysis *S) { return S->getKind() == SILAnalysisKind::BasicCallee; diff --git a/lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp b/lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp index 1f1b8009a21..cb4ddd547fe 100644 --- a/lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp +++ b/lib/SILOptimizer/Analysis/BasicCalleeAnalysis.cpp @@ -30,10 +30,6 @@ using namespace swift; -// TODO: can't be inlined to work around https://github.com/apple/swift/issues/64502 -BasicCalleeAnalysis::~BasicCalleeAnalysis() { -} - void BasicCalleeAnalysis::dump() const { print(llvm::errs()); }