averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Strip an unused DiagnosticEngine param

Browse Source
This commit is contained in:
Hamish Knight
2021-06-05 18:41:14 +01:00
parent 6d34fd9ed1
commit 2dac5b2ec6
1 changed files with 6 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
lib/IDE/Refactoring.cpp
View File

@@ -4851,8 +4851,7 @@ public:
Nodes.addNode(Node);
}
void addBinding(const ClassifiedCondition &FromCondition,
DiagnosticEngine &DiagEngine) {
void addBinding(const ClassifiedCondition &FromCondition) {
auto *P = FromCondition.BindPattern;
if (!P)
return;
@@ -4866,13 +4865,9 @@ public:
ParamPatternBindings[FromCondition.Subject].push_back(P);
}
void addAllBindings(const ClassifiedCallbackConditions &FromConditions,
DiagnosticEngine &DiagEngine) {
for (auto &Entry : FromConditions) {
addBinding(Entry.second, DiagEngine);
if (DiagEngine.hadAnyError())
return;
}
void addAllBindings(const ClassifiedCallbackConditions &FromConditions) {
for (auto &Entry : FromConditions)
addBinding(Entry.second);
}
};
@@ -5309,9 +5304,7 @@ private:
// comments.
CurrentBlock->addPossibleCommentLoc(Statement->getStartLoc());
ThenBlock->addAllBindings(CallbackConditions, DiagEngine);
if (DiagEngine.hadAnyError())
return;
ThenBlock->addAllBindings(CallbackConditions);
// TODO: Handle nested ifs
setNodes(ThenBlock, ElseBlock, std::move(ThenNodesToPrint));
@@ -5400,9 +5393,7 @@ private:
Block->addPossibleCommentLoc(SS->getRBraceLoc());
setNodes(Block, OtherBlock, std::move(SuccessNodes));
Block->addBinding(*CC, DiagEngine);
if (DiagEngine.hadAnyError())
return;
Block->addBinding(*CC);
}
// Mark this switch statement as having been transformed.
HandledSwitches.insert(SS);