averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

SIL: Rename long form of getOrCreateFunction() to createFunction(), NFC

Browse Source 
This made call sites confusing to read because it doesn't actually
check if the function already exists.

Also fix some minor formatting issues. This came up while I was working
on a fix for a bug that turned out to not be a bug.
This commit is contained in:
Slava Pestov
2016-04-21 16:18:48 -07:00
parent f8fcd0ce11
commit 2e52338d7c
14 changed files with 50 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
include/swift/SIL/SILModule.h
View File

@@ -455,7 +455,7 @@ public:
IsThunk_t isThunk);
/// \brief Return the declaration of a function, or create it if it doesn't
/// exist..
/// exist.
SILFunction *getOrCreateFunction(SILLocation loc,
StringRef name,
SILLinkage linkage,
@@ -468,18 +468,17 @@ public:
SILFunction::NotRelevant);
/// \brief Return the declaration of a function, or create it if it doesn't
/// exist..
/// exist.
SILFunction *getOrCreateFunction(SILLocation loc,
SILDeclRef constant,
ForDefinition_t forDefinition);
/// \brief Return the declaration of a function, or create it if it does not
/// exist.
/// \brief Create a function declaration.
///
/// This signature is a direct copy of the signature of SILFunction::create()
/// in order to simplify refactoring all SILFunction creation use-sites to use
/// SILModule. Eventually the uses should probably be refactored.
SILFunction *getOrCreateFunction(
SILFunction *createFunction(
SILLinkage linkage, StringRef name, CanSILFunctionType loweredType,
GenericParamList *contextGenericParams, Optional<SILLocation> loc,
IsBare_t isBareSILFunction, IsTransparent_t isTrans,