averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Revert "Merge pull request #26937 from rintaro/syntaxparse-leakfix"

Browse Source 
This reverts commit e49401bbca, reversing
changes made to bd222ad71c.
This commit is contained in:
Robert Widmann
2019-09-16 15:07:19 -07:00
parent f302da0f9b
commit 362b21926c
4 changed files with 32 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/Parse/SyntaxParsingContext.cpp
View File

@@ -256,9 +256,17 @@ ParsedRawSyntaxNode SyntaxParsingContext::finalizeSourceFile() {
Layout[1] = std::move(Parts.back());
Parts = Parts.drop_back();
assert(llvm::all_of(Parts, [](const ParsedRawSyntaxNode& node) {
return node.getKind() == SyntaxKind::CodeBlockItem;
}) && "all top level element must be 'CodeBlockItem'");
for (auto RawNode : Parts) {
if (RawNode.getKind() != SyntaxKind::CodeBlockItem) {
// FIXME: Skip toplevel garbage nodes for now. we shouldn't emit them in
// the first place.
if (RawNode.isRecorded())
getSyntaxCreator().finalizeNode(RawNode.getOpaqueNode());
continue;
}
AllTopLevel.push_back(RawNode);
}
Layout[0] = Recorder.recordRawSyntax(SyntaxKind::CodeBlockItemList, Parts);