averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

[move-only] Rename mark_must_check -> mark_unresolved_non_copyable_value.

Browse Source 
I was originally hoping to reuse mark_must_check for multiple types of checkers.
In practice, this is not what happened... so giving it a name specifically to do
with non copyable types makes more sense and makes the code clearer.

Just a pure rename.
This commit is contained in:
Michael Gottesman
2023-08-30 15:47:28 -07:00
parent 52c732fa92
commit 37d60a08bb
85 changed files with 1106 additions and 974 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/SIL/Verifier/SILVerifier.cpp
View File

@@ -681,7 +681,7 @@ struct ImmutableAddressUseVerifier {
case SILInstructionKind::IndexAddrInst:
case SILInstructionKind::TailAddrInst:
case SILInstructionKind::IndexRawPointerInst:
case SILInstructionKind::MarkMustCheckInst:
case SILInstructionKind::MarkUnresolvedNonCopyableValueInst:
case SILInstructionKind::CopyableToMoveOnlyWrapperValueInst:
case SILInstructionKind::PackElementGetInst:
// Add these to our worklist.
@@ -2606,7 +2606,7 @@ public:
"Must store to an address dest");
// Note: This is the current implementation and the design is not final.
auto isLegal = [](SILValue value) {
if (auto *mmci = dyn_cast<MarkMustCheckInst>(value))
if (auto *mmci = dyn_cast<MarkUnresolvedNonCopyableValueInst>(value))
value = mmci->getOperand();
return isa<AllocStackInst>(value);
};
@@ -6121,7 +6121,8 @@ public:
checkDropDeinitUses(ddi);
}
void checkMarkMustCheckInst(MarkMustCheckInst *i) {
void checkMarkUnresolvedNonCopyableValueInst(
MarkUnresolvedNonCopyableValueInst *i) {
require(i->getModule().getStage() == SILStage::Raw,
"Only valid in Raw SIL! Should have been eliminated by /some/ "
"diagnostic pass");