averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

swift-module-digester: diagnose adding/removing final as ABI/API breakages.

Browse Source
This commit is contained in:
Xi Ge
2018-10-08 13:19:54 -07:00
parent bfadd46d57
commit 382e27f4ab
7 changed files with 41 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tools/swift-api-digester/ModuleAnalyzerNodes.h
View File

@@ -129,9 +129,9 @@ public:
}
};
// Describing some attributes with ABI impact. The addition or removal of these
// attributes is considerred ABI-breaking.
struct ABIAttributeInfo {
// Describing some attributes with ABI/API impact. The addition or removal of these
// attributes is considerred breakage.
struct BreakingAttributeInfo {
const DeclAttrKind Kind;
const StringRef Content;
};
@@ -156,7 +156,7 @@ class SDKContext {
TypeMemberDiffVector TypeMemberDiffs;
CheckerOptions Opts;
std::vector<ABIAttributeInfo> ABIAttrs;
std::vector<BreakingAttributeInfo> BreakingAttrs;
/// This is to cache the equal comparison results between nodes.
llvm::DenseMap<const SDKNode*, llvm::DenseMap<const SDKNode*, bool>> EqualCache;
@@ -190,7 +190,7 @@ public:
bool checkingABI() const { return Opts.ABI; }
AccessLevel getAccessLevel(const ValueDecl *VD) const;
const CheckerOptions &getOpts() const { return Opts; }
ArrayRef<ABIAttributeInfo> getABIAttributeInfo() const { return ABIAttrs; }
ArrayRef<BreakingAttributeInfo> getBreakingAttributeInfo() const { return BreakingAttrs; }
template<class YAMLNodeTy, typename ...ArgTypes>
void diagnose(YAMLNodeTy node, Diag<ArgTypes...> ID,