mirror of
https://github.com/apple/swift.git
synced 2025-12-21 12:14:44 +01:00
[gardening] C++ gardening: Terminate namespaces, fix argument names, ...
Changes: * Terminate all namespaces with the correct closing comment. * Make sure argument names in comments match the corresponding parameter name. * Remove redundant get() calls on smart pointers. * Prefer using "override" or "final" instead of "virtual". Remove "virtual" where appropriate.
This commit is contained in:
@@ -151,11 +151,11 @@ static bool printAsObjC(const std::string &outputPath, Module *M,
|
||||
std::error_code EC;
|
||||
std::unique_ptr<llvm::raw_pwrite_stream> out =
|
||||
Clang.createOutputFile(outputPath, EC,
|
||||
/*binary=*/false,
|
||||
/*removeOnSignal=*/true,
|
||||
/*Binary=*/false,
|
||||
/*RemoveFileOnSignal=*/true,
|
||||
/*inputPath=*/"",
|
||||
path::extension(outputPath),
|
||||
/*temporary=*/true,
|
||||
/*UseTemporary=*/true,
|
||||
/*createDirs=*/false,
|
||||
/*finalPath=*/nullptr,
|
||||
&tmpFilePath);
|
||||
@@ -215,7 +215,7 @@ public:
|
||||
: OSPtr(std::move(OS)),
|
||||
FixitAll(DiagOpts.FixitCodeForAllDiagnostics) {}
|
||||
|
||||
~JSONFixitWriter() {
|
||||
~JSONFixitWriter() override {
|
||||
swift::writeEditsInJson(llvm::makeArrayRef(AllEdits), *OSPtr);
|
||||
}
|
||||
private:
|
||||
|
||||
Reference in New Issue
Block a user