[gardening] C++ gardening: Terminate namespaces, fix argument names, ...

Changes:
* Terminate all namespaces with the correct closing comment.
* Make sure argument names in comments match the corresponding parameter name.
* Remove redundant get() calls on smart pointers.
* Prefer using "override" or "final" instead of "virtual". Remove "virtual" where appropriate.
This commit is contained in:
practicalswift
2016-12-17 00:32:42 +01:00
parent 2ff90611a8
commit 38be6125e5
165 changed files with 508 additions and 505 deletions

View File

@@ -151,11 +151,11 @@ static bool printAsObjC(const std::string &outputPath, Module *M,
std::error_code EC;
std::unique_ptr<llvm::raw_pwrite_stream> out =
Clang.createOutputFile(outputPath, EC,
/*binary=*/false,
/*removeOnSignal=*/true,
/*Binary=*/false,
/*RemoveFileOnSignal=*/true,
/*inputPath=*/"",
path::extension(outputPath),
/*temporary=*/true,
/*UseTemporary=*/true,
/*createDirs=*/false,
/*finalPath=*/nullptr,
&tmpFilePath);
@@ -215,7 +215,7 @@ public:
: OSPtr(std::move(OS)),
FixitAll(DiagOpts.FixitCodeForAllDiagnostics) {}
~JSONFixitWriter() {
~JSONFixitWriter() override {
swift::writeEditsInJson(llvm::makeArrayRef(AllEdits), *OSPtr);
}
private: