averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-14 20:36:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Disable ASan in coroutine functions; it interferes with splitting.

Browse Source 
I filed rdar://43673059 to track re-enabling it.
This commit is contained in:
John McCall
2018-08-24 01:54:21 -04:00
parent 872463d6c6
commit 3a4185ca48
2 changed files with 23 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/IRGen/IRGenSIL.cpp
View File

@@ -1243,8 +1243,12 @@ IRGenSILFunction::IRGenSILFunction(IRGenModule &IGM,
// Apply sanitizer attributes to the function. // Apply sanitizer attributes to the function.
// TODO: Check if the function is supposed to be excluded from ASan either by // TODO: Check if the function is supposed to be excluded from ASan either by
// being in the external file or via annotations. // being in the external file or via annotations.
if (IGM.IRGen.Opts.Sanitizers & SanitizerKind::Address) if (IGM.IRGen.Opts.Sanitizers & SanitizerKind::Address) {
CurFn->addFnAttr(llvm::Attribute::SanitizeAddress); // Disable ASan in coroutines; stack poisoning is not going to do
// reasonable things to the structural invariants.
if (!f->getLoweredFunctionType()->isCoroutine())
CurFn->addFnAttr(llvm::Attribute::SanitizeAddress);
}
if (IGM.IRGen.Opts.Sanitizers & SanitizerKind::Thread) { if (IGM.IRGen.Opts.Sanitizers & SanitizerKind::Thread) {
auto declContext = f->getDeclContext(); auto declContext = f->getDeclContext();
if (declContext && isa<DestructorDecl>(declContext)) if (declContext && isa<DestructorDecl>(declContext))

20
test/IRGen/asan-attributes.swift
View File

@@ -1,8 +1,22 @@
// This test verifies that we add the function attributes used by ASan. // This test verifies that we add the function attributes used by ASan.
// RUN: %target-swift-frontend -assume-parsing-unqualified-ownership-sil -emit-ir -sanitize=address %s | %FileCheck %s -check-prefix=ASAN // RUN: %target-swift-frontend -emit-ir -disable-llvm-optzns -sanitize=address %s | %FileCheck %s -check-prefix=ASAN
func test() { // ASAN: define {{.*}} @"$S4main4testyyF"() [[DEFAULT_ATTRS:#[0-9]+]]
public func test() {
} }
// ASAN: Function Attrs: sanitize_address // ASAN: define {{.*}} @"$S4main1xSivr"({{.*}}) [[COROUTINE_ATTRS:#[0-9]+]]
public var x: Int {
_read {
yield 0
}
}
// ASAN: attributes [[DEFAULT_ATTRS]] =
// ASAN-SAME: sanitize_address
// ASAN-SAME: }
// ASAN: attributes [[COROUTINE_ATTRS]] =
// ASAN-NOT: sanitize_address
// ASAN-SAME: }