averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

SIL: Non-final public methods of resilient classes don't need public linkage

Browse Source 
Part of <rdar://problem/40432647>.
This commit is contained in:
Slava Pestov
2018-11-14 16:06:21 -05:00
parent 0741f6464c
commit 3b10ed5eaf
4 changed files with 41 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/SIL/SILDeclRef.cpp
View File

@@ -893,10 +893,14 @@ SubclassScope SILDeclRef::getSubclassScope() const {
return SubclassScope::NotApplicable;
// If this declaration is a function which goes into a vtable, then it's
// symbol must be as visible as its class. Derived classes even have to put
// symbol must be as visible as its class, because derived classes have to put
// all less visible methods of the base class into their vtables.
auto *FD = dyn_cast<AbstractFunctionDecl>(getDecl());
if (auto *CD = dyn_cast<ConstructorDecl>(getDecl()))
if (!CD->isRequired())
return SubclassScope::NotApplicable;
auto *FD = dyn_cast<FuncDecl>(getDecl());
if (!FD)
return SubclassScope::NotApplicable;
@@ -924,6 +928,9 @@ SubclassScope SILDeclRef::getSubclassScope() const {
assert(FD->getEffectiveAccess() <= classType->getEffectiveAccess() &&
"class must be as visible as its members");
if (classType->isResilient())
return SubclassScope::Resilient;
switch (classType->getEffectiveAccess()) {
case AccessLevel::Private:
case AccessLevel::FilePrivate:
@@ -932,8 +939,6 @@ SubclassScope SILDeclRef::getSubclassScope() const {
case AccessLevel::Public:
return SubclassScope::Internal;
case AccessLevel::Open:
if (classType->isResilient())
return SubclassScope::Internal;
return SubclassScope::External;
}