averello/swift-mirror
1
0
Fork 0
mirror of https://github.com/apple/swift.git synced 2025-12-21 12:14:44 +01:00
Code Issues Packages Projects Releases Wiki Activity

Runtime: use SmallVector instead of std::vector to avoid memory allocations in most cases.

Browse Source 
This dramatically reduces the number of needed malloc calls.
Unfortunately I had to add the implementation of SmallVectorBase::grow_pod to the runtime, as we don't link LLVM. This is a bad hack, but better than re-inventing a new SmallVector implementation.

SR-10028
rdar://problem/48575729
This commit is contained in:
Erik Eckstein
2019-03-04 14:26:40 -08:00
parent 9050be62de
commit 3bd7f027f8
8 changed files with 78 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
include/swift/Demangling/TypeDecoder.h
View File

@@ -315,7 +315,7 @@ class TypeDecoder {
if (Node->getNumChildren() < 2)
return BuiltType();
std::vector<BuiltType> args;
SmallVector<BuiltType, 8> args;
const auto &genericArgs = Node->getChild(1);
assert(genericArgs->getKind() == NodeKind::TypeList);
@@ -427,7 +427,7 @@ class TypeDecoder {
return BuiltType();
// Find the protocol list.
std::vector<BuiltProtocolDecl> Protocols;
SmallVector<BuiltProtocolDecl, 8> Protocols;
auto TypeList = Node->getChild(0);
if (TypeList->getKind() == NodeKind::ProtocolList &&
TypeList->getNumChildren() >= 1) {
@@ -514,7 +514,7 @@ class TypeDecoder {
return BuiltType();
bool hasParamFlags = false;
std::vector<FunctionParam<BuiltType>> parameters;
SmallVector<FunctionParam<BuiltType>, 8> parameters;
if (!decodeMangledFunctionInputType(Node->getChild(isThrow ? 1 : 0),
parameters, hasParamFlags))
return BuiltType();
@@ -531,9 +531,9 @@ class TypeDecoder {
}
case NodeKind::ImplFunctionType: {
auto calleeConvention = ImplParameterConvention::Direct_Unowned;
std::vector<ImplFunctionParam<BuiltType>> parameters;
std::vector<ImplFunctionResult<BuiltType>> results;
std::vector<ImplFunctionResult<BuiltType>> errorResults;
SmallVector<ImplFunctionParam<BuiltType>, 8> parameters;
SmallVector<ImplFunctionResult<BuiltType>, 8> results;
SmallVector<ImplFunctionResult<BuiltType>, 8> errorResults;
ImplFunctionTypeFlags flags;
for (unsigned i = 0; i < Node->getNumChildren(); i++) {
@@ -611,7 +611,7 @@ class TypeDecoder {
return decodeMangledType(Node->getChild(0));
case NodeKind::Tuple: {
std::vector<BuiltType> elements;
SmallVector<BuiltType, 8> elements;
std::string labels;
bool variadic = false;
for (auto &element : *Node) {
@@ -785,7 +785,7 @@ class TypeDecoder {
private:
template <typename T>
bool decodeImplFunctionPart(Demangle::NodePointer node,
std::vector<T> &results) {
SmallVectorImpl<T> &results) {
if (node->getNumChildren() != 2)
return true;
@@ -871,7 +871,7 @@ private:
bool decodeMangledFunctionInputType(
Demangle::NodePointer node,
std::vector<FunctionParam<BuiltType>> &params,
SmallVectorImpl<FunctionParam<BuiltType>> &params,
bool &hasParamFlags) {
// Look through a couple of sugar nodes.
if (node->getKind() == NodeKind::Type ||

8
include/swift/Reflection/TypeRefBuilder.h
View File

@@ -274,13 +274,13 @@ public:
const BoundGenericTypeRef *
createBoundGenericType(const Optional<std::string> &mangledName,
const std::vector<const TypeRef *> &args,
ArrayRef<const TypeRef *> args,
const TypeRef *parent) {
return BoundGenericTypeRef::create(*this, *mangledName, args, parent);
}
const TupleTypeRef *
createTupleType(const std::vector<const TypeRef *> &elements,
createTupleType(ArrayRef<const TypeRef *> elements,
std::string &&labels, bool isVariadic) {
// FIXME: Add uniqueness checks in TupleTypeRef::Profile and
// unittests/Reflection/TypeRef.cpp if using labels for identity.
@@ -288,7 +288,7 @@ public:
}
const FunctionTypeRef *createFunctionType(
const std::vector<remote::FunctionParam<const TypeRef *>> &params,
ArrayRef<remote::FunctionParam<const TypeRef *>> params,
const TypeRef *result, FunctionTypeFlags flags) {
return FunctionTypeRef::create(*this, params, result, flags);
}
@@ -406,7 +406,7 @@ public:
const ObjCClassTypeRef *
createBoundGenericObjCClassType(const std::string &name,
std::vector<const TypeRef *> &args) {
ArrayRef<const TypeRef *> args) {
// Remote reflection just ignores generic arguments for Objective-C
// lightweight generic types, since they don't affect layout.
return createObjCClassType(name);